[Marble-devel] Review Request 121332: Adding map theme name in the window title

Illya Kovalevskyy illya.kovalevskyy at gmail.com
Tue Dec 2 20:46:48 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121332/
-----------------------------------------------------------

(Updated Dec. 2, 2014, 10:46 p.m.)


Review request for Marble, Dennis Nienhüser and Torsten Rahn.


Changes
-------

Fixed title text issue


Repository: marble


Description
-------

This patch changes application title to "Marble - %MapName%". Important to notice that this behaviour is inherited by KDE version as well (inb4 kde-version used another format)

Related GCI-2014 task: http://www.google-melange.com/gci/task/view/google/gci2014/5250492930195456


Diffs (updated)
-----

  src/apps/marble-kde/KdeMainWindow.cpp 8a23006 
  src/apps/marble-qt/QtMainWindow.h eb5116d 
  src/apps/marble-qt/QtMainWindow.cpp 34bfc3c 

Diff: https://git.reviewboard.kde.org/r/121332/diff/


Testing
-------

KDE and Qt builds


File Attachments
----------------

Qt version
  https://git.reviewboard.kde.org/media/uploaded/files/2014/12/02/580f81d3-d683-42f2-b9d3-d7710f9de6b2__Screen_Shot_2014-12-02_at_10.11.03_PM.png
KDE version
  https://git.reviewboard.kde.org/media/uploaded/files/2014/12/02/ab0728f4-bb63-4375-9d0f-b2f6b0cdc81f__Screen_Shot_2014-12-02_at_10.10.03_PM.png


Thanks,

Illya Kovalevskyy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20141202/5be23204/attachment.html>


More information about the Marble-devel mailing list