[Marble-devel] Review Request: Allow to print the contents in WebPopup

Torsten Rahn tackat at kde.org
Fri Dec 28 23:01:32 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107993/#review24148
-----------------------------------------------------------



src/plugins/render/webpopup/PopupItem.cpp
<http://git.reviewboard.kde.org/r/107993/#comment18476>

    Showing the print button should also depend on 
    #ifndef QT_NO_PRINTER
    #endif
    otherwise the functionality will be in the UI but just wouldn't work!


- Torsten Rahn


On Dec. 28, 2012, 10:36 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107993/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2012, 10:36 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Description
> -------
> 
> It's allowed to print the contents of the Webkit View in WebPopup according to the GCI task:
>  - https://google-melange.appspot.com/gci/task/view/google/gci2012/8136208
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/webpopup/PopupItem.h 9be7f44 
>   src/plugins/render/webpopup/PopupItem.cpp a2ebe36 
> 
> Diff: http://git.reviewboard.kde.org/r/107993/diff/
> 
> 
> Testing
> -------
> 
> Built & Run & Tested on Kubuntu 12.10 with Qt 4.8.3
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121228/bf0a1eb4/attachment-0001.html>


More information about the Marble-devel mailing list