[Marble-devel] Review Request: Plasma Runner which starts Marble for entered lonlat coordinates

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102849/#review7358
-----------------------------------------------------------


Great initiative. I have no idea about the Plasma code, so I didn't review that one.


src/kdemain.cpp
<http://git.reviewboard.kde.org/r/102849/#comment6433>

    Could you add this to qtmain.cpp for consistency? 



src/kdemain.cpp
<http://git.reviewboard.kde.org/r/102849/#comment6434>

    see above.



src/kdemain.cpp
<http://git.reviewboard.kde.org/r/102849/#comment6435>

    That probably made you feel even more motivated about fixing the fromString method, right? ;-)


- Torsten Rahn


On Oct. 14, 2011, 8:20 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102849/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2011, 8:20 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Initial minimal version of my planned Plasma Runner. So far only detects lonlat coordinates and starts a new Marble showing that coordinates with OSM.
> Support for Marble runners and bookmarks is to come. And parsing needs to be improved, still. WIP.
> 
> Are commandline arguments for Marble okay?
> Discovers some rendering problems in Marble widget on start, someone might investigate that (no clue myself yet).
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt a0e4e7a 
>   src/kdemain.cpp eee55df 
>   src/plasmarunner/CMakeLists.txt PRE-CREATION 
>   src/plasmarunner/main.cpp PRE-CREATION 
>   src/plasmarunner/plasma-runner-marble.desktop PRE-CREATION 
>   src/plasmarunner/plasmarunner.h PRE-CREATION 
>   src/plasmarunner/plasmarunner.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102849/diff/diff
> 
> 
> Testing
> -------
> 
> Used a few times.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20111015/13eb1882/attachment.html>