[Marble-devel] Re: Review Request: Positionprovider-plugin using QtMobility

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101431/#review3494
-----------------------------------------------------------


Thanks for the quick update. A bit more nitpicking below ;-)


src/plugins/positionprovider/qtmobility/CMakeLists.txt
<http://git.reviewboard.kde.org/r/101431/#comment2951>

    I think it should rather be QtMobilityPositionProviderPlugin to match the directory/lib name



src/plugins/positionprovider/qtmobility/QtPositionProviderPlugin.cpp
<http://git.reviewboard.kde.org/r/101431/#comment2952>

    should return a const object or the method shouldn't be const



src/plugins/positionprovider/qtmobility/QtPositionProviderPlugin.cpp
<http://git.reviewboard.kde.org/r/101431/#comment2953>

    opening curly bracket should be on the line above



src/plugins/positionprovider/qtmobility/QtPositionProviderPlugin.cpp
<http://git.reviewboard.kde.org/r/101431/#comment2954>

    opening curly bracket should be on the line above



src/plugins/positionprovider/qtmobility/QtPositionProviderPlugin.cpp
<http://git.reviewboard.kde.org/r/101431/#comment2955>

    opening curly bracket should be on the line above



src/plugins/positionprovider/qtmobility/QtPositionProviderPlugin.cpp
<http://git.reviewboard.kde.org/r/101431/#comment2956>

    opening curly bracket should be on the line above


- Dennis


On May 24, 2011, 7:13 p.m., Daniel Marth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101431/
> -----------------------------------------------------------
> 
> (Updated May 24, 2011, 7:13 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Summary
> -------
> 
> Adds a positionprovider-plugin based on the QtMobility.
> 
> 
> Diffs
> -----
> 
>   FindQtLocation.cmake PRE-CREATION 
>   src/plugins/positionprovider/CMakeLists.txt c07c8bc 
>   src/plugins/positionprovider/qtmobility/CMakeLists.txt PRE-CREATION 
>   src/plugins/positionprovider/qtmobility/QtPositionProviderPlugin.h PRE-CREATION 
>   src/plugins/positionprovider/qtmobility/QtPositionProviderPlugin.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101431/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20110524/f4329faf/attachment.htm