[Marble-devel] Review Request: Fix KWorldClock plasmoid bug when using a localized version

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5323/#review7563
-----------------------------------------------------------

Ship it!


Looks good, please commit.


trunk/KDE/kdeedu/marble/src/plasmoid/worldclock.cpp
<http://svn.reviewboard.kde.org/r/5323/#comment7725>

    I tried to fix the crash in Marble as well, but setting the map theme as the first thing is a good idea anyway.



trunk/KDE/kdeedu/marble/src/plasmoid/worldclock.cpp
<http://svn.reviewboard.kde.org/r/5323/#comment7721>

    Uh. An euclidian distance is not sane here, should be MarbleMath::distanceSphere instead. Not your code, I know.
    


- Dennis


On 2010-09-12 11:05:28, Cristian Onet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5323/
> -----------------------------------------------------------
> 
> (Updated 2010-09-12 11:05:28)
> 
> 
> Review request for marble and Dennis Nienhüser.
> 
> 
> Summary
> -------
> 
> The BUG is caused by using a translated string as the value of m_locationkey (causing the invalid time) and not displaying the translated string when the time was correctly displayed on mouse hovering.
> This patch fixes both issues by always using the english string for m_locationkey (which is used for computing the correct timezone) and displaying the translated string upon rendering (and font calculations).
> 
> The moving of the setProjection statement after setMapThemeId was done to fix a crash when calling setProjection due to the fact that d->m_mapTheme is null until setMapThemeId is called.
> 
> 
> This addresses bug 240979.
>     https://bugs.kde.org/show_bug.cgi?id=240979
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeedu/marble/src/plasmoid/worldclock.cpp 1174375 
> 
> Diff: http://svn.reviewboard.kde.org/r/5323/diff
> 
> 
> Testing
> -------
> 
> Tested the scenario described in the bug report and it works as expected.
> 
> 
> Thanks,
> 
> Cristian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/marble-devel/attachments/20100912/fe6ef2f6/attachment-0001.htm