[Marble-devel] Re: Junior Job Patch for Review

Bernhard Beschow bbeschow at cs.tu-berlin.de
Tue Oct 5 10:27:14 CEST 2010


Hi!

Thanks for your patch, it looks already very good! Have you considered to preserve the last directory also across restarts of Marble?

Greetings,
Bernhard

Am Dienstag, 5. Oktober 2010, 06:50:08 schrieb prashant bhutani:
> Hi all,
> 
> For Qt version of the Junior Job[1] , I am attaching the patch file (as well
> as code[2] in this mail).
> I have tested it. It is working and remembering the directory last opened.
> Please review it and do tell me if I am wrong.
> 
> Thanks & Regards,
> Prashant Bhutani
> 
> [1]
> http://techbase.kde.org/Projects/Marble/GoMarble/JJ#Let_the_.22Open_....22_file_dialog_remember_the_previously_used_directory
> 
> [2] Here is the patch data ::
> *Index: trunk/marble/src/QtMainWindow.cpp
> ===================================================================
> --- trunk/marble/src/QtMainWindow.cpp    (revision 8)
> +++ trunk/marble/src/QtMainWindow.cpp    (revision 9)
> @@ -661,10 +661,15 @@
> 
>  void MainWindow::openFile()
>  {
> +    static QString currentDir = QString();
>      QStringList fileNames = QFileDialog::getOpenFileNames(this, tr("Open
> File"),
> -                            QString(),
> +                            currentDir,
>                              tr("All Supported Files (*.gpx *.kml);;GPS Data
> (*.gpx);;Google Earth KML (*.kml)"));
> 
> +    QDir dirObj;
> +
> +    currentDir = dirObj.absoluteFilePath( fileNames.at( fileNames.size()
> -1);
> +
>      foreach( const QString &fileName, fileNames ) {
>          QString extension = fileName.section( '.', -1 );*
> 



More information about the Marble-devel mailing list