[Marble-devel] Review Request: Replacing gpx classes with Geo data for position tracking

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4248/#review6105
-----------------------------------------------------------



/trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp
<http://reviewboard.kde.org/r/4248/#comment5692>

    Maybe you can exchange "gpsLocation" for "positionChanged(GeoDataCoordinates)" with this patch already?


- Torsten


On 2010-06-06 22:52:34, Thibaut Gridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4248/
> -----------------------------------------------------------
> 
> (Updated 2010-06-06 22:52:34)
> 
> 
> Review request for marble.
> 
> 
> Summary
> -------
> 
> This Patch series has been squashed to fit in RB.
> 
> First part uses GeoDataDocument and MarbleGeometryModel to resp feed a kml document and display it in marble.
> Secont part removes all code of gps/ and AbstractLayer/ as it is not used
> Third part adds styling in PositionTracking so that the GPS track is 2px wide and red.
> 
> Regressions/TODOs:
> - MarbleGeometryModel has always handled one document at a time, it should more than ever have all documents.
> If a file is opened concurrently with position tracking, only one can be displayed...
> 
> - We need more styling in GeoDataStyle to provide the much beloved dotted/arrowed path we always had.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeedu/marble/CMakeLists.txt 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/AbstractLayer/AbstractLayerContainer.h 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/AbstractLayer/AbstractLayerContainer.cpp 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/AbstractLayer/AbstractLayerData.h 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/AbstractLayer/AbstractLayerData.cpp 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/AbstractLayer/AbstractLayerInterface.h 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/AbstractLayer/AbstractLayerInterface.cpp 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/CMakeLists.txt 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleControlBox.cpp 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.h 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleMap.cpp 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.h 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleModel.cpp 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.h 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/MarbleWidget.cpp 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/Projections/AbstractProjection.h 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/Projections/AbstractProjection.cpp 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/GpsElement.h 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/GpsElement.cpp 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/GpxFile.h 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/GpxFile.cpp 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/GpxFileModel.h 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/GpxFileModel.cpp 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/GpxSax.h 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/GpxSax.cpp 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.h 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/PositionTracking.cpp 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/Route.h 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/Route.cpp 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/RouteContainer.h 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/RouteContainer.cpp 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/Track.h 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/Track.cpp 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/TrackContainer.h 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/TrackContainer.cpp 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/TrackPoint.h 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/TrackPoint.cpp 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/TrackSegment.h 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/TrackSegment.cpp 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/Waypoint.h 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/Waypoint.cpp 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/WaypointContainer.h 1135204 
>   /trunk/KDE/kdeedu/marble/src/lib/gps/WaypointContainer.cpp 1135204 
> 
> Diff: http://reviewboard.kde.org/r/4248/diff
> 
> 
> Testing
> -------
> 
> Plotting with gpsfake, enabling/disabling gpsd provider
> 
> 
> Thanks,
> 
> Thibaut
> 
>