[Marble-devel] [RFC] API cleanup, remove MarbleModel::setDownloadManager

[Jens-Michael Hoffmann]

Hi,

MarbleModel::setDownloadManager is not used anywhere in kde svn, imho there is 
no point in continuing to support this method, but maybe I'm wrong.

Comments welcome.



Best regards,

Jens-Michael


diff --git a/marble/src/lib/MarbleModel.cpp b/marble/src/lib/MarbleModel.cpp
index b074c98..e0f1df8 100644
--- a/marble/src/lib/MarbleModel.cpp
+++ b/marble/src/lib/MarbleModel.cpp
@@ -517,18 +517,6 @@ HttpDownloadManager* MarbleModel::downloadManager() const
     return d->m_downloadManager;
 }
 
-
-void MarbleModel::setDownloadManager( HttpDownloadManager *downloadManager )
-{
-    HttpDownloadManager *previousDownloadManager = d->m_downloadManager;
-
-    d->m_tileLoader->setDownloadManager( downloadManager );
-    d->m_downloadManager = downloadManager;
-
-    delete previousDownloadManager;
-}
-
-
 void MarbleModelPrivate::resize( int width, int height )
 {
     if ( m_mapTheme->map()->hasTextureLayers() ) {
diff --git a/marble/src/lib/MarbleModel.h b/marble/src/lib/MarbleModel.h
index 52010de..8620b56 100644
--- a/marble/src/lib/MarbleModel.h
+++ b/marble/src/lib/MarbleModel.h
@@ -190,16 +190,6 @@ class MARBLE_EXPORT MarbleModel : public QObject
 
     HttpDownloadManager* downloadManager() const;
 
-   /**
-     * @brief Set the downloadmanager to load missing tiles
-     * @param downloadManager the HttpDownloadManager instance
-     *
-     * This function sets the downloadmanager to load tiles that
-     * are missing locally. The desctruction of the instance
-     * will be handled by MarbleModel.
-     */
-    void setDownloadManager( HttpDownloadManager *downloadManager );
-
     void openGpxFile( const QString& filename );
     void addPlacemarkFile( const QString& filename );
     void addPlacemarkData( const QString& data, const QString& key = "data" 
);