[Marble-devel] Review Request: Download policies part 1, basic infrastructure

Jens-Michael Hoffmann jensmh at gmx.de
Thu Oct 1 12:04:39 CEST 2009


On Thursday, 1. October 2009 11:00:28 Torsten Rahn wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1745/#review2512
> -----------------------------------------------------------
> 
> Ship it!
> 
> 
> Wow, this looks nice to me. Much nicer to read.
> Only nitpicks: License headers seem to be missing at least for the
>  DownloadPolicy classes And in the nice HttpJob lifecycle documentation I
>  guess it should be m_activeJobs (instead of m_activatedJobs).
Committed with license headers added and wrong identifier fixed, thanks for 
pointing out.


Best regards,

Jens-Michael


More information about the Marble-devel mailing list