<table><tr><td style="">dhaumann added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27533">View Revision</a></tr></table><br /><div><div><p>Ok, then I am fine with this. Maybe add a KF6 task to the KF6 board?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27533#inline-155749">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kossebau</span> wrote in <span style="color: #4b4d51; font-weight: bold;">katedocument.h:86</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">See the warning in the API docs, nobody should rely on this private API, so the BIC here is okay.<br />
The class is exported for the unit tests basically.<br />
Also is the header file not installed, so not really available outside.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Friedrich is correct. We have no issue here.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27533#inline-155776">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katedocument.h:586</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QHash</span><span style="color: #aa2211"><</span><span style="color: #aa4000">int</span><span class="p">,</span> <span class="n">KTextEditor</span><span style="color: #aa2211">::</span><span class="n">Mark</span> <span style="color: #aa2211">*></span> <span class="n">m_marks</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">QHash</span><span style="color: #aa2211"><</span><span style="color: #aa4000">int</span><span class="p">,</span> <span class="n">Q<span class="bright">Pixmap</span></span><span style="color: #aa2211">></span> <span class="n">m_markPixmap<span class="bright">s</span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QHash</span><span style="color: #aa2211"><</span><span style="color: #aa4000">int</span><span class="p">,</span> <span class="n">Q<span class="bright">Variant</span></span><span style="color: #aa2211">></span> <span class="n">m_mark<span class="bright">Icons</span></span><span class="bright"></span><span class="p"><span class="bright">;</span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">// QPixmap or QIcon, KF6: remove Q</span>Pixmap<span class="bright"> support</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QHash</span><span style="color: #aa2211"><</span><span style="color: #aa4000">int</span><span class="p">,</span> <span class="n">QString</span><span style="color: #aa2211">></span> <span class="n">m_markDescriptions</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Better turn " Remove pixmap support" into use QIcon only.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27533#inline-155777">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katesearchbar.cpp:906</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">m_highlightRanges</span><span class="p">.</span><span class="n">empty</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">KTextEditor</span><span style="color: #aa2211">::</span><span class="n">MarkInterface</span> <span style="color: #aa2211">*</span><span class="n">iface</span> <span style="color: #aa2211">=</span> <span class="n">qobject_cast</span><span style="color: #aa2211"><</span><span class="n">KTextEditor</span><span style="color: #aa2211">::</span><span class="n">MarkInterface</span> <span style="color: #aa2211">*></span><span class="p">(</span><span class="n">m_view</span><span style="color: #aa2211">-></span><span class="n">document</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">KTextEditor</span><span style="color: #aa2211">::</span><span class="n">MarkInterface<span class="bright">V2</span></span> <span style="color: #aa2211">*</span><span class="n">iface</span> <span style="color: #aa2211">=</span> <span class="n">qobject_cast</span><span style="color: #aa2211"><</span><span class="n">KTextEditor</span><span style="color: #aa2211">::</span><span class="n">MarkInterface<span class="bright">V2</span></span> <span style="color: #aa2211">*></span><span class="p">(</span><span class="n">m_view</span><span style="color: #aa2211">-></span><span class="n">document</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">iface</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">maybe use <tt style="background: #ebebeb; font-size: 13px;">auto</tt> here.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27533#inline-155575">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kossebau</span> wrote in <span style="color: #4b4d51; font-weight: bold;">kateviewhelpers.cpp:1963</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Possibly <tt style="background: #ebebeb; font-size: 13px;">QIcon::paint()</tt> might be also working here as wanted? Needs someone with HiDPI to check if all things behave as wanted. The old code with all the <tt style="background: #ebebeb; font-size: 13px;">devicePixelRatioF()</tt> made me change not too much here.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I believe you can check yourself with proper environment variables, or?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R39 KTextEditor</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27533">https://phabricator.kde.org/D27533</a></div></div><br /><div><strong>To: </strong>kossebau, Kate, KDevelop<br /><strong>Cc: </strong>anthonyfieroni, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars<br /></div>