<table><tr><td style="">ahmadsamir added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22477">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D22477#496059" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D22477#496059</a>, <a href="https://phabricator.kde.org/p/kossebau/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@kossebau</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Default is <tt style="background: #ebebeb; font-size: 13px;">false,</tt> so does not change behaviour unless someone toggles the switch, right?</p>
<p>I would rename the option to <tt style="background: #ebebeb; font-size: 13px;">WordCompletionMatchFromWordStartOnly</tt> though, as from what I can tell completion often only does from start, and matching also in the word is an extra feature. Edit: as in, reading <tt style="background: #ebebeb; font-size: 13px;">WordCompletionMatchFromWordStart</tt>in the code triggered with me "yes, what else? MatchFromEnd?"</p></div>
</blockquote>
<p>Noted. Thought I most likely didn't add "only" because the config name was becoming rather too long, but you have a point.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Actually, perhaps that whole option could/should be even an enum for 3 cases:<br />
a) from full word start<br />
b) from subword start (CamelCase, _) <br />
c) match anywhere in word.<br />
I vaguely remember some cases where I got annoyed by cross-subword hits accidentally creating a match.</p></blockquote>
<p>a and b are already in the MatchType enum, StartsWithMatch and ContainsMatch respectively, the new config is overriding the current behaviour where if there's no StartsWithMatch, it goes to the ContainsMatch route. As for c, I think that would be too many completions, the accuracy would be blown to bits...</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R39 KTextEditor</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22477">https://phabricator.kde.org/D22477</a></div></div><br /><div><strong>To: </strong>ahmadsamir, KTextEditor, cullmann, dhaumann, KDevelop, kossebau, mwolff, kfunk<br /><strong>Cc: </strong>kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann<br /></div>