<table><tr><td style="">nibags added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22253">View Revision</a></tr></table><br /><div><div><p>Now I checked the patch well and I want to add some final recommendations before merging.<br />
I think it's okay.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22253#inline-125464">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fortran-fixed.xml:368</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><context</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"Normal Text"</span> <span style="color: #354bb3">lineEndContext=</span><span style="color: #766510">"#stay"</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"default"</span> <span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><IncludeRules</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"find_strings"</span> <span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><IncludeRules</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"find_decls"</span> <span style="color: #00702a">/></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I recommend moving lines 374 and 375 (<tt style="background: #ebebeb; font-size: 13px;"><IncludeRules context="find_preprocessor" /></tt> and <tt style="background: #ebebeb; font-size: 13px;"><IncludeRules context="find_comments" /></tt>) to the beginning of the "default" context so that they have higher priority. For example, when writing a number on column 72, it's not highlighted as a comment, because numbers have a higher priority.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22253#inline-125465">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fortran-fixed.xml:411</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><DetectChar</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"Comment"</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"comment"</span> <span style="color: #354bb3">char=</span><span style="color: #766510">"!"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><RegExpr</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"Comment"</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"comment"</span> <span style="color: #354bb3">String=</span><span style="color: #766510">".*"</span> <span style="color: #354bb3">column=</span><span style="color: #766510">"72"</span> <span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"></context></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Here put <tt style="background: #ebebeb; font-size: 13px;">String="."</tt> instead of <tt style="background: #ebebeb; font-size: 13px;">".*"</tt>, because this also highlights alerts in the comment line (for example: TODO, NOTE, ALERT).</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R216 Syntax Highlighting</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22253">https://phabricator.kde.org/D22253</a></div></div><br /><div><strong>To: </strong>nononux<br /><strong>Cc: </strong>nibags, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann<br /></div>