<table><tr><td style="">dhaumann added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22199">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22199#inline-125185">View Inline</a><span style="color: #4b4d51; font-weight: bold;">plugin_kateopenselection.cpp:91</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">KTextEditor</span><span style="color: #aa2211">::</span><span class="n">View</span><span style="color: #aa2211">*</span> <span class="n">editView</span> <span style="color: #aa2211">=</span> <span class="n">application</span><span style="color: #aa2211">-></span><span class="n">activeMainWindow</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">activeView</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">editView</span> <span style="color: #aa2211">&&</span> <span class="n">editView</span><span style="color: #aa2211">-></span><span class="n">document</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QString</span> <span class="n">selection</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">A view always has a valid document, no need to check editView->document()</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22199#inline-125181">View Inline</a><span style="color: #4b4d51; font-weight: bold;">plugin_kateopenselection.cpp:107</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">const</span> <span class="n">KTextEditor</span><span style="color: #aa2211">::</span><span class="n">Cursor</span> <span style="color: #aa2211">&</span><span class="n">cursor</span> <span style="color: #aa2211">=</span> <span class="n">editView</span><span style="color: #aa2211">-></span><span class="n">cursorPosition</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">const</span> <span class="n">QString</span> <span style="color: #aa2211">&</span><span class="n">line</span> <span style="color: #aa2211">=</span> <span class="n">editView</span><span style="color: #aa2211">-></span><span class="n">document</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">line</span><span class="p">(</span><span class="n">cursor</span><span class="p">.</span><span class="n">line</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">lineLength</span> <span style="color: #aa2211">=</span> <span class="n">line</span><span class="p">.</span><span class="n">size</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">QString is implicitly shared. Please remove the '&' here.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22199#inline-125182">View Inline</a><span style="color: #4b4d51; font-weight: bold;">plugin_kateopenselection.cpp:112</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">col</span> <span style="color: #aa2211">=</span> <span class="n">cursor</span><span class="p">.</span><span class="n">column</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">int</span> <span class="n">start</span><span style="color: #aa2211">=</span><span class="n">col</span><span class="p">,</span> <span class="n">end</span><span style="color: #aa2211">=</span><span class="n">col</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #74777d">// Stop at first white space or quote (for path with space, user should select the text)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">In general: Please use spaces around operators and adhere to the standard KDE coding guidelines (also used in Kate everywhere else).</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R40 Kate</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22199">https://phabricator.kde.org/D22199</a></div></div><br /><div><strong>To: </strong>nononux<br /><strong>Cc: </strong>dhaumann, pino, yurchor, kwrite-devel, kde-doc-english, gennad, fbampaloukas, domson, michaelh, ngraham, demsking, skadinna, cullmann, sars<br /></div>