<table><tr><td style="">nononux added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21713">View Revision</a></tr></table><br /><div><div><p>Hi, thanks for the patch. I suggest additionnal changes to improve the syntax highlighting for Fortran fixed format.</p>
<p>I write fixed format fortran at least once a week using Kate. I can confirm these modifications will be usefull at least for me ;)<br />
I tested the proposed changes on this file www.unige.ch/~hairer/prog/nonstiff/dop853.f (+ add some characters to test the comments highlighting after the 72th column).</p>
<p>Unfortunately I don't see how to write the changes without regular expressions, but I've only low knowledge on syntax highlighting files.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21713#inline-125238">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fortran-fixed.xml:375</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><IncludeRules</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"find_preprocessor"</span> <span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><IncludeRules</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"find_comments"</span> <span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><IncludeRules</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"find_symbols"</span> <span style="color: #00702a">/></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I propose to add this (why below)</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><IncludeRules context="find_continue" /></pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21713#inline-125237">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fortran-fixed.xml:408</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><context</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"Normal Text"</span> <span style="color: #354bb3">lineEndContext=</span><span style="color: #766510">"#stay"</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"find_comments"</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><AnyChar</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"Comment"</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"comment"</span> <span style="color: #354bb3">String=</span><span style="color: #766510">"cC*"</span> <span style="color: #354bb3">column=</span><span style="color: #766510">"0"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #00702a"><DetectChar</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"Comment"</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"comment"</span> <span style="color: #354bb3">char=</span><span style="color: #766510">"!"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"></context></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I propose to add theses lines:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><DetectChar attribute="Comment" context="comment" char="!"/>
<RegExpr attribute="Comment" context="comment" String=".*" column="72" /></pre></div>
<p style="padding: 0; margin: 8px;">1st line : The "!" can be used even in fixed format. It can be used at any place in the line to comment the end of the line<br />
2nd line : The characters after the 72th column are ignored by the compiler. So it's easier for the user if they are marked as a comment.</p>
<p style="padding: 0; margin: 8px;">ref : my everyday use of Fortran + <a href="https://docs.oracle.com/cd/E19957-01/805-4939/6j4m0vn6l/index.html" class="remarkup-link" target="_blank" rel="noreferrer">https://docs.oracle.com/cd/E19957-01/805-4939/6j4m0vn6l/index.html</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21713#inline-125239">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fortran-fixed.xml:424</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"></context></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d"><!-- This context highlights items inside the parentesis of a function --></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I propose to add this (with the line above) :</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><!-- This context highlights the continuation character -->
<context attribute="Normal Text" lineEndContext="#stay" name="find_continue">
<RegExpr attribute="Continuation character" context="#stay" String="^ [^0-9\s]"/>
</context></pre></div>
<p style="padding: 0; margin: 8px;">If the 5 firsts characters are blank and the 6th is not blank and not a number, this indicate a continuation character (usually "&" or "*").<br />
It will be easier for the user to place the continuation character at the right column if it is coloured.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21713#inline-125240">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fortran-fixed.xml:569</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><itemData</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"IO Function"</span> <span style="color: #354bb3">defStyleNum=</span><span style="color: #766510">"dsFunction"</span> <span style="color: #354bb3">bold=</span><span style="color: #766510">"0"</span> <span style="color: #354bb3">italic=</span><span style="color: #766510">"0"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><itemData</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"Elemental Procedure"</span> <span style="color: #354bb3">defStyleNum=</span><span style="color: #766510">"dsBuiltIn"</span> <span style="color: #354bb3">bold=</span><span style="color: #766510">"1"</span> <span style="color: #354bb3">italic=</span><span style="color: #766510">"0"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><itemData</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"Inquiry Function"</span> <span style="color: #354bb3">defStyleNum=</span><span style="color: #766510">"dsFunction"</span> <span style="color: #354bb3">bold=</span><span style="color: #766510">"1"</span> <span style="color: #354bb3">italic=</span><span style="color: #766510">"1"</span><span style="color: #00702a">/></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">To complete the above modification:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><itemData name="Continuation character" defStyleNum="dsBuiltIn" bold="1" italic="0"/></pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R216 Syntax Highlighting</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21713">https://phabricator.kde.org/D21713</a></div></div><br /><div><strong>To: </strong>nibags, Framework: Syntax Highlighting, dhaumann, cullmann<br /><strong>Cc: </strong>nononux, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann<br /></div>