<table><tr><td style="">ahmadsamir updated this revision to Diff 54149.<br />ahmadsamir added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18793">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">
<li class="remarkup-list-item">Split the code responsible for inserting text in block selection from typeChars() to a new function</li>
<li class="remarkup-list-item">Don't add words where the block selection cursor is inside to the possible completion matches from the document</li>
<li class="remarkup-list-item">Add unit test</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R39 KTextEditor</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D18793?vs=52658&id=54149">https://phabricator.kde.org/D18793?vs=52658&id=54149</a></div></div><br /><div><strong>BRANCH</strong><div><div>block-selection-completion-3 (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18793">https://phabricator.kde.org/D18793</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/src/completion_test.cpp<br />
autotests/src/completion_test.h<br />
src/completion/katewordcompletion.cpp<br />
src/document/katedocument.cpp<br />
src/document/katedocument.h</div></div></div><br /><div><strong>To: </strong>ahmadsamir, KTextEditor, cullmann, dhaumann, KDevelop, mwolff<br /><strong>Cc: </strong>loh.tar, mwolff, kde-frameworks-devel, kwrite-devel, KTextEditor, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann<br /></div>