<table><tr><td style="">loh.tar added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19517">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Just to be on the safe side: Does this also work, if you have two views visible showing the same document, and then the message appears?</p></blockquote>
<p>As said, poor tested., but what needs to be taken care? Normally these messages works well, so no idea why now not.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Does it also work, if you have two main windows showing the same document (View > New Window)?</p></blockquote>
<p>Do you mean something else than this hint?</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>One issue may/is that in case of multible views/windows the actions only get synced after an reload event :-/</p></blockquote>
<p>A tip how to solve this may helpful.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19517#inline-110215">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dhaumann</span> wrote in <span style="color: #4b4d51; font-weight: bold;">kateview.cpp:238-239</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Could you use new-style signal/slot syntax for new code? :)</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Yeah, normally I do. Here I was not sure if it will keeped/accepted and only did lazy copy old code :-)</p>
<p style="padding: 0; margin: 8px;">BTW I'm surprised that such function (slot) didn't alrady exist. Instead will in the doc all views at some points directly called to update some things. See e.g. DocumentPrivate::documentReload:4310</p></div></div></div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19517">https://phabricator.kde.org/D19517</a></div></div><br /><div><strong>To: </strong>loh.tar, KTextEditor, cullmann<br /><strong>Cc: </strong>dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, KTextEditor, gennad, domson, michaelh, ngraham, bruns, demsking, sars<br /></div>