<table><tr><td style="">vkrause created this revision.<br />Herald added projects: Kate, Frameworks.<br />Herald added subscribers: kde-frameworks-devel, kwrite-devel.<br />vkrause requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19453">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Since <a href="https://phabricator.kde.org/R216:6166da7503e676210a59954677b5de39b7980a61" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">6166da75</a> the invalid/default Definition has a name ("None"), so<br />
this check also triggers on that one, all the time. Instead check the<br />
definition file name, that doesn't exist for an invalid Definition.</p>
<p>See also <a href="https://phabricator.kde.org/D19432" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D19432</a>, which triggered this.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R216 Syntax Highlighting</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19453">https://phabricator.kde.org/D19453</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/lib/abstracthighlighter.cpp</div></div></div><br /><div><strong>To: </strong>vkrause<br /><strong>Cc: </strong>kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann<br /></div>