<table><tr><td style="">cullmann requested changes to this revision.<br />cullmann added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18948">View Revision</a></tr></table><br /><div><div><p>You can add a unit test, you just need to add a small .syntax file in addition to the test, e.g. see</p>
<p><a href="https://cgit.kde.org/syntax-highlighting.git/tree/autotests/input/adblock.txt.syntax" class="remarkup-link" target="_blank" rel="noreferrer">https://cgit.kde.org/syntax-highlighting.git/tree/autotests/input/adblock.txt.syntax</a></p>
<p>If you add a test, this can go in.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R216 Syntax Highlighting</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18948">https://phabricator.kde.org/D18948</a></div></div><br /><div><strong>To: </strong>nibags, Framework: Syntax Highlighting, dhaumann, cullmann<br /><strong>Cc: </strong>kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann<br /></div>