<table><tr><td style="">dhaumann added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18734">View Revision</a></tr></table><br /><div><div><p>Could you also switch to WordDetect for the trivial cases, and set kateversion="5.0" ?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18734#inline-104039">View Inline</a><span style="color: #4b4d51; font-weight: bold;">octave.xml:2690-2711</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #00702a"><RegExpr</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"#stay"</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"Keyword"</span> <span style="color: #354bb3">String=</span><span style="color: #766510">"\b(if)\b"</span> <span style="color: #354bb3">beginRegion=</span><span style="color: #766510">"block"</span> <span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #00702a"><RegExpr</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"#stay"</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"Keyword"</span> <span style="color: #354bb3">String=</span><span style="color: #766510">"\b(endif)\b"</span> <span style="color: #354bb3">endRegion=</span><span style="color: #766510">"block"</span> <span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #00702a"><RegExpr</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"#stay"</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"Keyword"</span> <span style="color: #354bb3">String=</span><span style="color: #766510">"\b(do)\b"</span> <span style="color: #354bb3">beginRegion=</span><span style="color: #766510">"block"</span> <span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #00702a"><RegExpr</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"#stay"</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"Keyword"</span> <span style="color: #354bb3">String=</span><span style="color: #766510">"\b(until)\b"</span> <span style="color: #354bb3">endRegion=</span><span style="color: #766510">"block"</span> <span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #00702a"><RegExpr</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"#stay"</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"Keyword"</span> <span style="color: #354bb3">String=</span><span style="color: #766510">"\b(while)\b"</span> <span style="color: #354bb3">beginRegion=</span><span style="color: #766510">"block"</span> <span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #00702a"><RegExpr</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"#stay"</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"Keyword"</span> <span style="color: #354bb3">String=</span><span style="color: #766510">"\b(endwhile)\b"</span> <span style="color: #354bb3">endRegion=</span><span style="color: #766510">"block"</span> <span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #00702a"><RegExpr</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"#stay"</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"Keyword"</span> <span style="color: #354bb3">String=</span><span style="color: #766510">"\b(function)\b"</span> <span style="color: #354bb3">beginRegion=</span><span style="color: #766510">"block"</span> <span style="color: #00702a">/></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">While you are working on this, could you change all RegExpr that use the simple \b...\b form into a WordDetect form? See: <a href="https://docs.kde.org/trunk5/en/applications/katepart/highlight.html" class="remarkup-link" target="_blank" rel="noreferrer">https://docs.kde.org/trunk5/en/applications/katepart/highlight.html</a></p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><WordDetect attribute=... String="function" .../></pre></div>

<p style="padding: 0; margin: 8px;">This would be much faster than general purpose RegExps.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R216 Syntax Highlighting</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18734">https://phabricator.kde.org/D18734</a></div></div><br /><div><strong>To: </strong>sirgienko, Framework: Syntax Highlighting<br /><strong>Cc: </strong>dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars<br /></div>