<table><tr><td style="">dhaumann added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18164">View Revision</a></tr></table><br /><div><div><p>I like the idea to go to next modified line up / down. I am undecided about the goto line in clipboard, since I have the feeling it adds more clutter than it helps by default: I think <CTRL+G> <CTRL+V> <ENTER> is quite fast. In addition, this leads to having "Gehe zu" twice in the ui, which is a bit confusing imho. Other opinions?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18164#inline-100948">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katedialogs.cpp:1099</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">btn</span><span style="color: #aa2211">-></span><span class="n">setIcon</span><span class="p">(</span><span class="n">QIcon</span><span style="color: #aa2211">::</span><span class="n">fromTheme</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"go-up-search"</span><span class="p">)));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">btn</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">""</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">btn</span><span style="color: #aa2211">-></span><span class="n">installEventFilter</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please always use QString() in favor of QStringLiteral("")</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18164#inline-100953">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katedialogs.cpp:1156</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">message</span><span style="color: #aa2211">-></span><span class="n">setAutoHide</span><span class="p">(</span><span style="color: #601200">2000</span><span class="p">);</span> <span style="color: #74777d">// FIXME Timer is not started as I would expect, only after some "unclear" event</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">message</span><span style="color: #aa2211">-></span><span class="n">setPosition</span><span class="p">(</span><span class="n">KTextEditor</span><span style="color: #aa2211">::</span><span class="n">Message</span><span style="color: #aa2211">::</span><span class="n">BottomInView</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_view</span><span style="color: #aa2211">-></span><span class="n">document</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">postMessage</span><span class="p">(</span><span class="n">message</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You should also call message->setView(m_view), otherwise the message appears in all views, in case you have multiple views of a document.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18164#inline-100951">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katedialogs.h:103</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QSpinBox</span> <span style="color: #aa2211">*</span><span class="n">gotoRange</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QSpinBox</span> <span style="color: #aa2211">*<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">m_</span>gotoRange<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">nullptr</span></span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QToolButton</span> <span style="color: #aa2211">*</span><span class="n">m_ModifiedUp</span> <span style="color: #aa2211">=</span> <span class="n">nullptr</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QToolButton</span> <span style="color: #aa2211">*</span><span class="n">m_ModifiedDown</span> <span style="color: #aa2211">=</span> <span class="n">nullptr</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Could you use lowercase naming here? m_modifiedUp instead of m_ModifiedUp?</p></div></div></div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18164">https://phabricator.kde.org/D18164</a></div></div><br /><div><strong>To: </strong>loh.tar, KTextEditor<br /><strong>Cc: </strong>dhaumann, cullmann, anthonyfieroni, kwrite-devel, kde-frameworks-devel, KTextEditor, hase, michaelh, ngraham, bruns, demsking, sars<br /></div>