<table><tr><td style="">gregormi added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18083">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D18083#392525" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D18083#392525</a>, <a href="https://phabricator.kde.org/p/sars/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@sars</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>My personal taste would be to only have a small tool-tip saying: See the "Add.." context menu entry for regular expression help.</p>
<p>The search plugin is already cluttered with a lot of buttons...</p></div>
</blockquote>
<p>I would agree but for me the context menu way is one bit too long ("right-click, go down to Add..., click or wait to open, select item" instead of "left-click, select item"). And harder to discover.</p>
<p>Would it help to add an option in the context menu to hide the new line edit buttons? :-) Or to somehow remove contrast from the icons?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18083#inline-100593">View Inline</a><span style="color: #4b4d51; font-weight: bold;">sars</span> wrote in <span style="color: #4b4d51; font-weight: bold;">plugin_search.cpp:58</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">I prefer static functions over unnamed namespaces as you immediately see the static declaration, while functions in a namespace can be far away from the namespace keyword.</p>
<p style="padding: 0; margin: 8px;">Besides this change is unrelated to the functionality change.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'll change that accordingly.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18083#inline-100595">View Inline</a><span style="color: #4b4d51; font-weight: bold;">sars</span> wrote in <span style="color: #4b4d51; font-weight: bold;">plugin_search.cpp:461</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Note that this icon is not available with gnome icon theme. you need to specify that Kate depends on Breeze icon theme and actually have it installed to get this icon...</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I looked at the Regex toggle button code:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">QIcon useRegExpIcon = QIcon::fromTheme(QStringLiteral("code-context"), QIcon::fromTheme(QStringLiteral("edit-find-replace")));</pre></div>
<p style="padding: 0; margin: 8px;">and didn't know that the second parameter is a fallback. I'll copy that.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R40 Kate</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18083">https://phabricator.kde.org/D18083</a></div></div><br /><div><strong>To: </strong>gregormi, Kate<br /><strong>Cc: </strong>dhaumann, loh.tar, sars, kwrite-devel, hase, michaelh, ngraham, demsking, cullmann<br /></div>