<table><tr><td style="">sars added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18083">View Revision</a></tr></table><br /><div><div><p>My personal taste would be to only have a small tool-tip saying: See the "Add.." context menu entry for regular expression help.</p>

<p>The search plugin is already cluttered with a lot of buttons...</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18083#inline-100593">View Inline</a><span style="color: #4b4d51; font-weight: bold;">plugin_search.cpp:58</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"></span><span style="color: #aa4000"><span class="bright">static</span></span><span class="bright"> </span><span class="n"><span class="bright">QUrl</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">localFileDirUp</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span class="n"><span class="bright">QUrl</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&</span></span><span class="bright"></span><span class="n"><span class="bright">url</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"></span><span style="color: #aa4000"><span class="bright">namespace</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I prefer static functions over unnamed namespaces as you immediately see the static declaration, while functions in a namespace can be far away from the namespace keyword.</p>

<p style="padding: 0; margin: 8px;">Besides this change is unrelated to the functionality change.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D18083#inline-100595">View Inline</a><span style="color: #4b4d51; font-weight: bold;">plugin_search.cpp:461</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">m_ui</span><span class="p">.</span><span class="n">searchCombo</span><span style="color: #aa2211">-></span><span class="n">setMaxCount</span><span class="p">(</span><span style="color: #601200">25</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QAction</span><span style="color: #aa2211">*</span> <span class="n">searchComboActionForInsertRegexButton</span> <span style="color: #aa2211">=</span> <span class="n">m_ui</span><span class="p">.</span><span class="n">searchCombo</span><span style="color: #aa2211">-></span><span class="n">lineEdit</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">addAction</span><span class="p">(</span><span class="n">QIcon</span><span style="color: #aa2211">::</span><span class="n">fromTheme</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"code-context"</span><span class="p">)),</span> <span class="n">QLineEdit</span><span style="color: #aa2211">::</span><span class="n">TrailingPosition</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">connect</span><span class="p">(</span><span class="n">searchComboActionForInsertRegexButton</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">QAction</span><span style="color: #aa2211">::</span><span class="n">triggered</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa4000">this</span><span class="p">]()</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Note that this icon is not available with gnome icon theme. you need to specify that Kate depends on Breeze icon theme and actually have it installed to get this icon...</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R40 Kate</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D18083">https://phabricator.kde.org/D18083</a></div></div><br /><div><strong>To: </strong>gregormi, Kate<br /><strong>Cc: </strong>dhaumann, loh.tar, sars, kwrite-devel, hase, michaelh, ngraham, demsking, cullmann<br /></div>