<table><tr><td style="">gregormi added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17442">View Revision</a></tr></table><br /><div><div><p>With respect to bringing this <a href="https://phabricator.kde.org/T10279" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/T10279</a> forward, how should I proceed here? Can this go in as first step (after I removed F10 and F11)? (see also <a href="https://phabricator.kde.org/D17443" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D17443</a>)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17442#inline-100515">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kateview.cpp:700</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">ac</span><span style="color: #aa2211">-></span><span class="n">addAction</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"view_dynamic_word_wrap"</span><span class="p">),</span> <span class="n">a</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">ac</span><span style="color: #aa2211">-></span><span class="n">setDefaultShortcut</span><span class="p">(</span><span class="n">a</span><span class="p">,</span> <span class="n">QKeySequence</span><span class="p">(</span><span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">Key_F10</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">ac</span><span style="color: #aa2211">-></span><span class="n">setDefaultShortcut<span class="bright">s</span></span><span class="p">(</span><span class="n">a</span><span class="p">,</span> <span class="bright"></span><span class="p"><span class="bright">{</span></span><span class="bright"> </span><span class="n">QKeySequence</span><span class="p">(</span><span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">Key_F10</span><span class="p">)<span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">QKeySequence</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">Qt</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">CTRL</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="n"><span class="bright">Qt</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">Key_E</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">Qt</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">CTRL</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="n"><span class="bright">Qt</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">Key_W</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">}</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">a</span><span style="color: #aa2211">-></span><span class="n">setWhatsThis</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"If this option is checked, the text lines will be wrapped at the view border on the screen."</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">todo: Remove F10</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17442#inline-100516">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kateview.cpp:727</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">ac</span><span style="color: #aa2211">-></span><span class="n">addAction</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"view_line_numbers"</span><span class="p">),</span> <span class="n">a</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">ac</span><span style="color: #aa2211">-></span><span class="n">setDefaultShortcut</span><span class="p">(</span><span class="n">a</span><span class="p">,</span> <span class="n">QKeySequence</span><span class="p">(</span><span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">Key_F11</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">ac</span><span style="color: #aa2211">-></span><span class="n">setDefaultShortcut<span class="bright">s</span></span><span class="p">(</span><span class="n">a</span><span class="p">,</span> <span class="bright"></span><span class="p"><span class="bright">{</span></span><span class="bright"> </span><span class="n">QKeySequence</span><span class="p">(</span><span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">Key_F11</span><span class="p">)<span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">QKeySequence</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">Qt</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">CTRL</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="n"><span class="bright">Qt</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">Key_E</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">Qt</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">CTRL</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span class="n"><span class="bright">Qt</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">Key_L</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">}</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">a</span><span style="color: #aa2211">-></span><span class="n">setWhatsThis</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Show/hide the line numbers on the left hand side of the view."</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">todo: remove F11</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R39 KTextEditor</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17442">https://phabricator.kde.org/D17442</a></div></div><br /><div><strong>To: </strong>gregormi, Kate<br /><strong>Cc: </strong>cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, demsking, sars<br /></div>