<table><tr><td style="">mwolff resigned from this revision.<br />mwolff added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17599">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17599#inline-100418">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katemainwindow.cpp:1200</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">closedByUser</span> <span style="color: #aa2211">&&</span> <span class="n">KateApp</span><span style="color: #aa2211">::</span><span class="n">self</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">documentManager</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">documentList</span><span class="p">().</span><span class="n">count</span><span class="p">()</span> <span style="color: #aa2211">></span> <span style="color: #601200">1</span> <span style="color: #aa2211">&&</span> <span class="n">KateApp</span><span style="color: #aa2211">::</span><span class="n">self</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">mainWindowsCount</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #601200">1</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">KGuiItem</span> <span class="n">yes</span><span class="p">(</span><span class="n">i18nc</span><span class="p">(</span><span style="color: #766510">"@action:button 'Quit Kate' button"</span><span class="p">,</span> <span style="color: #766510">"&Quit %1"</span><span class="p">,</span> <span class="n">QGuiApplication</span><span style="color: #aa2211">::</span><span class="n">applicationDisplayName</span><span class="p">()),</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">introduce three more locals to make this line less long:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">const bool closedByUser = !qApp->isSavingSession();
const bool numDocuments = KateApp::self()->documentManager()->documentList().count();
const bool numWindows = KateApp::self()->mainWindowsCount();
const bool askConfirmation = closedByUser && numDocuments > 1 && numWindows == 1;

if (askConfirmation) {
 ...</pre></div>

<p style="padding: 0; margin: 8px;">why is the number of windows affecting this btw? I mean when I close a window with multiple tabs, it should ask for confirmation, no? Why is this only asked when there is just one window?</p>

<p style="padding: 0; margin: 8px;">Note that closing a single window is different from quitting the application.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R40 Kate</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17599">https://phabricator.kde.org/D17599</a></div></div><br /><div><strong>To: </strong>shubham, dhaumann, Kate, sars<br /><strong>Cc: </strong>mwolff, ngraham, pino, kwrite-devel, hase, michaelh, demsking, cullmann, sars, dhaumann<br /></div>