<table><tr><td style="">dhaumann added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D17295">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D17295#inline-95559">View Inline</a><span style="color: #4b4d51; font-weight: bold;">brightscript.xml:290</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #00702a"><DetectSpaces/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #00702a"><<span class="bright">keyword</span></span> <span style="color: #354bb3">String=</span><span style="color: #766510">"end"</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"function_end"</span> <span style="color: #354bb3">lookAhead=</span><span style="color: #766510">"true"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #00702a"><keyword</span> <span style="color: #354bb3">String=</span><span style="color: #766510">"endfunction"</span> <span class="bright"></span><span style="color: #354bb3"><span class="bright">attribute=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"keyword"</span></span><span class="bright"> </span><span style="color: #354bb3">context=</span><span style="color: #766510">"#pop<span class="bright">#pop</span>"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><<span class="bright">RegExpr</span></span> <span style="color: #354bb3">String=</span><span style="color: #766510">"end<span class="bright">\s+function"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">insensitive=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"true</span>"</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"<span class="bright">#pop!</span>function<span class="bright">_solid</span>_end"</span> <span style="color: #354bb3">lookAhead=</span><span style="color: #766510">"true"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><keyword</span> <span style="color: #354bb3">String=</span><span style="color: #766510">"endfunction"</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"#pop<span class="bright">!function_solid_end"</span></span><span class="bright"> </span><span style="color: #354bb3"><span class="bright">lookAhead=</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"true</span>"</span><span style="color: #00702a">/></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Since this context is not used anymore, we gen a warning while creating the highlighting index:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">[ 9%] Generating index.katesyntax
testkatehighlightingindexer(31350)/(default) ::KeywordChecker::check: "/home/dh/kde/kf5/src/frameworks/syntax-highlighting/data/syntax/brightscript.xml" Unused keyword lists: QSet("end")</pre></div>
<p style="padding: 0; margin: 8px;">--> the keyword list end should be removed, since unused.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R216 Syntax Highlighting</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D17295">https://phabricator.kde.org/D17295</a></div></div><br /><div><strong>To: </strong>dlevin, cullmann<br /><strong>Cc: </strong>dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars<br /></div>