<table><tr><td style="">gregormi added a subscriber: cullmann.<br />gregormi added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16830">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16830#inline-94741">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katefileactions.cpp:42-50</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">void</span> <span class="n">KateFileActions</span><span style="color: #aa2211">::</span><span class="n">copyFilePathToClipboard</span><span class="p">(</span><span class="n">KTextEditor</span><span style="color: #aa2211">::</span><span class="n">Document</span><span style="color: #aa2211">*</span> <span class="n">doc</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QApplication</span><span style="color: #aa2211">::</span><span class="n">clipboard</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">setText</span><span class="p">(</span><span class="n">doc</span><span style="color: #aa2211">-></span><span class="n">url</span><span class="p">().</span><span class="n">toDisplayString</span><span class="p">(</span><span class="n">QUrl</span><span style="color: #aa2211">::</span><span class="n">PreferLocalFile</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #aa4000">void</span> <span class="n">KateFileActions</span><span style="color: #aa2211">::</span><span class="n">openContainingFolder</span><span class="p">(</span><span class="n">KTextEditor</span><span style="color: #aa2211">::</span><span class="n">Document</span><span style="color: #aa2211">*</span> <span class="n">doc</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Hello <a href="https://phabricator.kde.org/p/dhaumann/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dhaumann</a> <a href="https://phabricator.kde.org/p/cullmann/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@cullmann</a>,<br />
I wonder if it would be better for the functions in this file to use a Document reference instead of a pointer. Currently, these functions will crash on a nullptr. In a function farther down below I used assertions which could be removed if I use references instead of pointers. This makes the code more readable and safe (and seems the recommended way to pass parameters: <a href="http://www.modernescpp.com/index.php/c-core-guidelines-how-to-pass-function-parameters" class="remarkup-link" target="_blank" rel="noreferrer">http://www.modernescpp.com/index.php/c-core-guidelines-how-to-pass-function-parameters</a>).<br />
What do you think?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R40 Kate</div></div></div><br /><div><strong>BRANCH</strong><div><div>arcpatch-D16830_1</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16830">https://phabricator.kde.org/D16830</a></div></div><br /><div><strong>To: </strong>gregormi, Kate, VDG, ngraham<br /><strong>Cc: </strong>cullmann, anthonyfieroni, dhaumann, mmustac, ngraham, kwrite-devel, hase, michaelh, demsking, sars<br /></div>