<table><tr><td style="">loh.tar added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16926">View Revision</a></tr></table><br /><div><div><p><a href="https://phabricator.kde.org/p/ngraham/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ngraham</a> Thanks for the VDG/screenshot advice, will hopefully remember that the next time :-)</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>The bottom-most button should be aligned to the bottom of the list box, as <a href="https://phabricator.kde.org/p/cullmann/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@cullmann</a> suggested</p></blockquote>
<p>Oh, I misread that, sorry. Somehow was "Open button" in my mind, that's because my answer about grouping.</p>
<p>The space(r) is there to avoid unneeded "Mouse-Meters" :-) Consider any default dialog where the horizontal buttons also placed at one side (usually right) and not at opposite ends. Here they are vertical at the top.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>The Close button should probably be renamed "Select" or "Choose" so it's clear that the selected session will be made the active one</p></blockquote>
<p>The Close button close the dialog, like Abort. If you mean to rename "Open" I can do it. But IIRC was the old dialog buttons named the way as they are currently.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>"Copy As..." would be better worded as "Duplicate..."</p></blockquote>
<p>Can do it, but "Copy As..." is something I have often seen, "Duplicate..." on the other hand (?)</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>The Sort Alphabetical button should be a combobox with the different sorting options</p></blockquote>
<p>That would be less handy, and unneeded annoying. Do you notice that the caption will changed when you click on it?</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>the Don't ask again checkbox. What's being asked?</p></blockquote>
<p>It's borrowed from the removed (old) KateSessionChooser dialog and only shown in "Chooser Mode". Guess it was there named "Always use this choice" but that text was too long and would break the nice layout. I didn't find a better place for that. How about at tool tip text as hint?</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>It's not clear what the New Anonymous ... do</p></blockquote>
<p>Old naming was "New Session"</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>and Open as Template buttons do</p></blockquote>
<p>Keep all settings, but don't open documents, as new anonymous session. See also <a href="https://phabricator.kde.org/D16926#360472" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D16926#360472</a></p>
<p><a href="https://phabricator.kde.org/p/anthonyfieroni/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@anthonyfieroni</a> Will do it.</p>
<p>But let me explain that I always keep such a like comments there to show you guys that my shipped solution is the result from a couple of considerations. Sometimes to avoid unneeded questions, sometimes to request suggestions for better solutions, sometimes to inform you that there could be something generally improved. In the latter case with the hope you say, "No, because.." or "Yes, would be great, (will trigger some guy | please do it)"</p>
<hr class="remarkup-hr" />
<p>Would be nice to get some more opinions, and clear advice how to fix some of these obscurities, if really needed.</p>
<p>Additionally shot of the unfixed dialog in "Manager Mode". Notice the different window title, order of entries (hard to find, sorry), caption of the sort button, gone check box and how the buttons are placed when the window has more height.<br />
<a href="https://phabricator.kde.org/F6442557" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6442557: 1543242921.png</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R40 Kate</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16926">https://phabricator.kde.org/D16926</a></div></div><br /><div><strong>To: </strong>loh.tar, Kate, dhaumann, ngraham, VDG<br /><strong>Cc: </strong>anthonyfieroni, cullmann, kwrite-devel, Kate, michaelh, ngraham, demsking, sars, dhaumann<br /></div>