<table><tr><td style="">dhaumann added subscribers: ngraham, dhaumann.<br />dhaumann added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16370">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16370#inline-90680">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katemodeconfigpage.cpp:95</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// having to increase the priority of (all) those definitions.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ui</span><span style="color: #aa2211">-></span><span class="n">sbPriority</span><span style="color: #aa2211">-></span><span class="n">setMinimum</span><span class="p">(</span><span style="color: #aa2211">-</span><span class="n">ui</span><span style="color: #aa2211">-></span><span class="n">sbPriority</span><span style="color: #aa2211">-></span><span class="n">maximum</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// make the context help a bit easier to access</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I would prefer to set this in the ui file: The maximum is already set to 99. I think it makes sense to set the minimum to -99 there. Can you provide an updated patch?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16370#inline-90681">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katemodeconfigpage.cpp:97</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// make the context help a bit easier to access</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">ui</span><span style="color: #aa2211">-></span><span class="n">sbPriority</span><span style="color: #aa2211">-></span><span class="n">setToolTip</span><span class="p">(</span><span class="n">ui</span><span style="color: #aa2211">-></span><span class="n">sbPriority</span><span style="color: #aa2211">-></span><span class="n">whatsThis</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I agree with Christoph, we have no tooltip anywhere so far, so this would be inconsistent.</p>
<p style="padding: 0; margin: 8px;"><a href="https://phabricator.kde.org/p/ngraham/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ngraham</a> Do you have any comment on this from a usability perspective? I have the feeling that how to show whats-this infos should be maybe solved in a more general way, and not for just one specific spin box.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R39 KTextEditor</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16370">https://phabricator.kde.org/D16370</a></div></div><br /><div><strong>To: </strong>rjvbb, KTextEditor<br /><strong>Cc: </strong>dhaumann, ngraham, cullmann, kde-frameworks-devel, kwrite-devel, michaelh, bruns, demsking, head7, kfunk, sars<br /></div>