<table><tr><td style="">dhaumann requested changes to this revision.<br />dhaumann added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16416">View Revision</a></tr></table><br /><div><div><p>Could you explain what CLIST is used for? Please add a small test file that is also MIT licensed.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16416#inline-89515">View Inline</a><span style="color: #4b4d51; font-weight: bold;">clist.xml:3</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96"><!DOCTYPE language SYSTEM "language.dtd"></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #00702a"><language</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"CLIST"</span> <span style="color: #354bb3">version=</span><span style="color: #766510">"2"</span> <span style="color: #354bb3">kateversion=</span><span style="color: #766510">"2.2"</span> <span style="color: #354bb3">section=</span><span style="color: #766510">"Scripts"</span> <span style="color: #354bb3">extensions=</span><span style="color: #766510">"*.clist;*.CLIST"</span> <span style="color: #354bb3">mimetype=</span><span style="color: #766510">""</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><highlighting></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">license="MIT" is missing.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16416#inline-89516">View Inline</a><span style="color: #4b4d51; font-weight: bold;">clist.xml:3</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96"><!DOCTYPE language SYSTEM "language.dtd"></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #00702a"><language</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"CLIST"</span> <span style="color: #354bb3">version=</span><span style="color: #766510">"2"</span> <span style="color: #354bb3">kateversion=</span><span style="color: #766510">"2.2"</span> <span style="color: #354bb3">section=</span><span style="color: #766510">"Scripts"</span> <span style="color: #354bb3">extensions=</span><span style="color: #766510">"*.clist;*.CLIST"</span> <span style="color: #354bb3">mimetype=</span><span style="color: #766510">""</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><highlighting></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">kateversion="5.0", or are you indeed using an old Kate before Plasma5?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16416#inline-89517">View Inline</a><span style="color: #4b4d51; font-weight: bold;">clist.xml:61</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"></context></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><context</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"Comment"</span> <span style="color: #354bb3">lineEndContext=</span><span style="color: #766510">"#stay"</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"Commentar 1"</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><RegExpr</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"Alert"</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"#stay"</span> <span style="color: #354bb3">String=</span><span style="color: #766510">"(FIXME|TODO)"</span> <span style="color: #00702a">/></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Maybe rename Commentar 1 to simply Comment? It seems you copy & pasted the file :)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16416#inline-89513">View Inline</a><span style="color: #4b4d51; font-weight: bold;">clist.xml:62</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><context</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"Comment"</span> <span style="color: #354bb3">lineEndContext=</span><span style="color: #766510">"#stay"</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"Commentar 1"</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><RegExpr</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"Alert"</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"#stay"</span> <span style="color: #354bb3">String=</span><span style="color: #766510">"(FIXME|TODO)"</span> <span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><Detect2Chars</span> <span style="color: #354bb3">attribute=</span><span style="color: #766510">"Comment"</span> <span style="color: #354bb3">context=</span><span style="color: #766510">"#pop"</span> <span style="color: #354bb3">char=</span><span style="color: #766510">"*"</span> <span style="color: #354bb3">char1=</span><span style="color: #766510">"/"</span> <span style="color: #354bb3">endRegion=</span><span style="color: #766510">"Comment"</span><span style="color: #00702a">/></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please use IncludeRules with ##Alerts, look into other highlighting files how this is done.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16416#inline-89514">View Inline</a><span style="color: #4b4d51; font-weight: bold;">clist.xml:69</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><itemData</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"Comment"</span> <span style="color: #354bb3">defStyleNum=</span><span style="color: #766510">"dsComment"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><itemData</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"Control"</span> <span style="color: #354bb3">defStyleNum=</span><span style="color: #766510">"dsNormal"</span> <span style="color: #354bb3">color=</span><span style="color: #766510">"#000090"</span><span style="color: #00702a">/></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><itemData</span> <span style="color: #354bb3">name=</span><span style="color: #766510">"Assignment"</span> <span style="color: #354bb3">defStyleNum=</span><span style="color: #766510">"dsBuiltIn"</span><span style="color: #00702a">/></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please remove the hard coded color. Hard coded colors are an issue with different color schemes. See <a href="https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/" class="remarkup-link" target="_blank" rel="noreferrer">https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/</a> for more default styles.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R216 Syntax Highlighting</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16416">https://phabricator.kde.org/D16416</a></div></div><br /><div><strong>To: </strong>phily, Framework: Syntax Highlighting, dhaumann<br /><strong>Cc: </strong>dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars<br /></div>