<table><tr><td style="">loh.tar updated this revision to Diff 39186.<br />loh.tar added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14620">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I'm ready to accept this patch.</p></blockquote>
<p>Wow, good news, thanks!<br />
But now I'm curious which part of my text was so persuasive.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Except for the actionTriggered() function</p></blockquote>
<p>Woops! That start was not so nice. Next time please add a hint for more information below ;-)</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>What I meant was that you could move this line to parseSymbols() and not add a new "wrapper" function with only one extra line of code...</p></blockquote>
<p>I found a second line I have missed :-)</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>...If you absolutely want to save the one setEnabled() for the timer-based document update,</p></blockquote>
<p>As said I want to save there the settings too. And that would then be unneeded often done.<br />
Independently of that would it look not right to me that menu morph to do in parseSymbols().</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>please use a more descriptive name like displayOptionChanged() or something similar.</p></blockquote>
<p>With pleasure. Good suggestion!</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Examples of options that are not saved when changed from menus: View -> font size changes, View -> Word wrap -> *, View -> Border -> *, Tools -> Spelling -> *,....</p></blockquote>
<p>Thanks for the list.<br />
"Word wrap" and "Spelling" are both annoying. I have so often to fumble unneeded with that.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>It is a design decision to have permanent changes in the settings pages and temporary document specific changes in the menus.</p></blockquote>
<p>Almost good, and right. But! ;-)<br />
The wrong parts there are</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">that these "permanent changes in the settings page" should only be "presets" when you choose an unseen document or create a new one (so far working) and</li>
<li class="remarkup-list-item">that the changes done in the menu should be saved permanent in relation to the current document (can't give a test case, but I think it's not working or at least buggy)</li>
</ul>
<p>That said, we have no "new document" in our context where we really need a preset. We have only fixed types of documents and I have doubts that it would make sense to view one C++ file with "this" and another C++ file with "that" settings.</p>
<p>So, how about to remove that page?</p>
<p>At least should there "Display functions parameters" be removed. It's only supported by three parser: cpp, php, ruby</p>
<p>Later I want remove/replace the fixed options m_macro, m_struct, m_func with some more flexible and fitting solution. I think I have made a FIXME note about this.</p>
<p>Greetings, Lothar</p></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D14620?vs=39114&id=39186">https://phabricator.kde.org/D14620?vs=39114&id=39186</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14620">https://phabricator.kde.org/D14620</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>addons/symbolviewer/bash_parser.cpp<br />
addons/symbolviewer/cpp_parser.cpp<br />
addons/symbolviewer/ecma_parser.cpp<br />
addons/symbolviewer/fortran_parser.cpp<br />
addons/symbolviewer/perl_parser.cpp<br />
addons/symbolviewer/php_parser.cpp<br />
addons/symbolviewer/plugin_katesymbolviewer.cpp<br />
addons/symbolviewer/plugin_katesymbolviewer.h<br />
addons/symbolviewer/python_parser.cpp<br />
addons/symbolviewer/ruby_parser.cpp<br />
addons/symbolviewer/tcl_parser.cpp<br />
addons/symbolviewer/xslt_parser.cpp</div></div></div><br /><div><strong>To: </strong>loh.tar, Kate, sars<br /><strong>Cc: </strong>sars, kwrite-devel, Kate, michaelh, kevinapavew, ngraham, demsking, cullmann, dhaumann<br /></div>