<table><tr><td style="">sars added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14620">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D14620#303899" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D14620#303899</a>, <a href="https://phabricator.kde.org/p/loh.tar/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@loh.tar</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Do you miss the update in <a href="https://phabricator.kde.org/D14518" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D14518</a> too?</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>The changes in the settings page is permanent, while the changes in the popup-menu is temporary -> I don't want to get rid of the settings page.</p></blockquote>
<p>As said, it can/will be saved automatic. Then it is permanent and that page useless.</p></div>
</blockquote>
<p>That would work differently from the rest of KTextEditor options, which would not be a good thing.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;">
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>do we need actionTriggered()?</p></blockquote>
<p>Yes. Doing so in parseSymbols() is unneeded often</p></blockquote>
<p>But we are not there yet. Now we have bool+action -> action change. The actionTriggered() seems to be part of a change that you have in mind to do but have not presented yet.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>if I manually toggle the tree it should stay that way also if the document is changed.</p></blockquote>
<p>That's how it will be work</p></blockquote>
<p>Nice :)</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>As said, I want for each parser/document type independent saved settings</p></blockquote>
<p>If we would save the state for each plugin and type separately, this m_expandOn action is not needed at all... And again saving the settings directly from the popup would be different from the rest of Kate where popup menus only are temporary changes.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;">
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>At the moment it expands/collapses all the tree-nodes.</p></blockquote>
<p>This is how it works. All or nothing. There is no other possibility</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I did not want the name-change ;)</p></blockquote>
<p>Anyone else out there who like my patch <a href="https://phabricator.kde.org/D14611" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D14611</a>?</p></blockquote>
<p>Regards,</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Kåre</pre></div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14620">https://phabricator.kde.org/D14620</a></div></div><br /><div><strong>To: </strong>loh.tar, Kate, sars<br /><strong>Cc: </strong>sars, kwrite-devel, Kate, michaelh, kevinapavew, ngraham, demsking, cullmann, dhaumann<br /></div>