<table><tr><td style="">nibags created this revision.<br />Restricted Application added projects: Kate, Frameworks.<br />Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel.<br />nibags requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14274">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Changes:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Add missing keyword: <tt style="background: #ebebeb; font-size: 13px;">byte-order-mark</tt> (there is only "byte-order-marker" and "bom"). Obtained from: <a href="https://docs.kde.org/stable5/en/applications/katepart/config-variables.html" class="remarkup-link" target="_blank" rel="noreferrer">https://docs.kde.org/stable5/en/applications/katepart/config-variables.html</a></li>
<li class="remarkup-list-item">Remove keywords delimiters "*" and "+", because in the "RemoveSpacesOptions" list, the keywords "*" and "+" are not highlighted.</li>
<li class="remarkup-list-item">Fix ";" in the "RemoveSpaces" context ("remove-trailing-spaces" variable). The character ";" it is not highlighted as in the rest of the variables, since when writing a value, the context ends.</li>
<li class="remarkup-list-item">For a strange reason, the use of <tt style="background: #ebebeb; font-size: 13px;"><IncludeRules context="##Modelines"/></tt>, in others files, causes the line continuation character ("\") to be highlighted as <tt style="background: #ebebeb; font-size: 13px;">dsNormal</tt>. This is solved by removing the LineContinue rule in the "Normal" context in Modelines. I consider the LineContinue & DetectSpaces rules to be unnecessary in the "Normal" context, so I've eliminated them.</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R216 Syntax Highlighting</div></div></div><br /><div><strong>BRANCH</strong><div><div>fix-modelines</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14274">https://phabricator.kde.org/D14274</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/reference/highlight.css.ref<br />
autotests/reference/review128925-1.css.ref<br />
autotests/reference/review128925-2.css.ref<br />
data/syntax/modelines.xml</div></div></div><br /><div><strong>To: </strong>nibags<br /><strong>Cc: </strong>kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann<br /></div>