<table><tr><td style="">zhigalin accepted this revision.<br />zhigalin added a subscriber: broulik.<br />zhigalin added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11785">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D11785#245911" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D11785#245911</a>, <a href="https://phabricator.kde.org/p/dhaumann/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@dhaumann</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Indeed, maybe this class should be part of the KConfigWidgets framework? See <a href="https://api.kde.org/frameworks/kconfigwidgets/html/annotated.html" class="remarkup-link" target="_blank" rel="noreferrer">https://api.kde.org/frameworks/kconfigwidgets/html/annotated.html</a> for current list of classes - it already contains the color scheme stuff and is a tier3 framework (so many dependencies allowed).</p>
<p><a href="https://phabricator.kde.org/p/zhigalin/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@zhigalin</a> Any comments from your side?</p></div>
</blockquote>
<p>Sorry for the late reply, haven't noticed this review before.<br />
As I said previously:</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Now KDelelop also allows scheme selection, but I still think this should become a standard functionality, maybe something like <tt style="background: #ebebeb; font-size: 13px;">KStandardAction::configureColors(KXmlGuiWindow *win);</tt></p></blockquote>
<p>And this is a reply by <a href="https://phabricator.kde.org/p/broulik/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@broulik</a></p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>If, and only if, we were to add something like that, we could add it to KXmlGui and have it provide a settings dialog in the settings menu where you also find eg. "Configure Toolbars".</p>
<p>The infrastructure is already there, KWin can even follow the colorscheme of an application to colorize the title bar accordingly. However, with KColorSchemeManager there's an easy-to-use class that applications that want to provide such functionality (eg. Krita, KDevelop, Gwenview, Dragon Player) > can add to their settings without further complicating the already insane customizability of our applications.</p></blockquote></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11785#inline-68320">View Inline</a><span style="color: #4b4d51; font-weight: bold;">katecolorschemechooser.h:39</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">*/</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">class</span> <span style="color: #a0a000">KateColorSchemeChooser</span> <span class="p">:</span> <span class="n">public</span> <span class="n">QAction</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">KateColorSchemeChooser</tt> may be a bit misleading as there is also the Editor color scheme which is different... <br />
Maybe it should be like <tt style="background: #ebebeb; font-size: 13px;">KateGuiColorsChooser</tt> or <tt style="background: #ebebeb; font-size: 13px;">KateWindowColorChooser</tt>?<br />
The rest looks good to me.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R40 Kate</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11785">https://phabricator.kde.org/D11785</a></div></div><br /><div><strong>To: </strong>tfjellstrom, Kate, zhigalin<br /><strong>Cc: </strong>broulik, apol, kwrite-devel, zhigalin, dhaumann, ngraham, cullmann, mwolff, michaelh, kevinapavew, demsking, sars<br /></div>