<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128908/">https://git.reviewboard.kde.org/r/128908/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Bump. Does someone want to review/import this RR?</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think this Review Request needs to be moved to Phabricator since Reviewboard is closed down soon.</p></pre>
<br />
<p>- Gregor Mi</p>
<br />
<p>On Dezember 20th, 2017, 12:17 vorm. UTC, Yunhe Guo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Kate, Dominik Haumann and Volker Krause.</div>
<div>By Yunhe Guo.</div>
<p style="color: grey;"><em>Updated Dez. 20, 2017, 12:17 vorm.</em></p>
<div style="margin-top: 1.5em;">
<strong style="color: #575012; font-size: 10pt;">Repository: </strong>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Blade template (<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">*.blade.php</code>) is a simple PHP template engine used in Laravel framework.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">https://laravel.com/docs/master/blade</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Screenshot:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">http://imgur.com/WOYV4Qu</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Test file:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span></span>@extends(<span style="border: 1px solid #FF0000">'</span>layouts.app<span style="border: 1px solid #FF0000">'</span>, [
<span style="border: 1px solid #FF0000">'</span>title<span style="border: 1px solid #FF0000">'</span> <span style="color: #666666">=></span> trans(<span style="border: 1px solid #FF0000">'</span>common.edit<span style="border: 1px solid #FF0000">'</span>) . <span style="border: 1px solid #FF0000">'</span><span style="color: #666666">:</span> <span style="border: 1px solid #FF0000">'</span> . <span style="border: 1px solid #FF0000">$</span>tag<span style="color: #666666">-></span>text(<span style="border: 1px solid #FF0000">'</span>name<span style="border: 1px solid #FF0000">'</span>),
<span style="border: 1px solid #FF0000">'</span>body_id<span style="border: 1px solid #FF0000">'</span> <span style="color: #666666">=></span> <span style="border: 1px solid #FF0000">'</span>tag<span style="color: #666666">-</span>edit<span style="color: #666666">-</span>page<span style="border: 1px solid #FF0000">'</span>,
<span style="border: 1px solid #FF0000">'</span>body_classes<span style="border: 1px solid #FF0000">'</span> <span style="color: #666666">=></span> [<span style="border: 1px solid #FF0000">'</span>tag<span style="color: #666666">-</span>edit<span style="color: #666666">-</span>page<span style="border: 1px solid #FF0000">'</span>, <span style="border: 1px solid #FF0000">'</span>tag<span style="color: #666666">-</span>page<span style="border: 1px solid #FF0000">'</span>, <span style="border: 1px solid #FF0000">'</span>edit<span style="color: #666666">-</span>page<span style="border: 1px solid #FF0000">'</span>],
<span style="border: 1px solid #FF0000">'</span>active_nav<span style="border: 1px solid #FF0000">'</span> <span style="color: #666666">=></span> parse_url(<span style="border: 1px solid #FF0000">$</span>_SERVER[<span style="border: 1px solid #FF0000">'</span>REQUEST_URI<span style="border: 1px solid #FF0000">'</span>], PHP_URL_PATH),
])
@section(<span style="border: 1px solid #FF0000">'</span>header<span style="border: 1px solid #FF0000">'</span>)
<span style="color: #666666"><</span>div <span style="color: #008000; font-weight: bold">class</span><span style="color: #666666">=</span><span style="color: #BA2121">"container"</span><span style="color: #666666">></span>
<span style="color: #666666"><</span>h1 <span style="color: #008000; font-weight: bold">class</span><span style="color: #666666">=</span><span style="color: #BA2121">"page-header"</span><span style="color: #666666">></span>{{ trans(<span style="border: 1px solid #FF0000">'</span>common.edit<span style="border: 1px solid #FF0000">'</span>) }}<span style="color: #666666">:</span> {{ <span style="border: 1px solid #FF0000">$</span>tag<span style="color: #666666">-></span>text(<span style="border: 1px solid #FF0000">'</span>name<span style="border: 1px solid #FF0000">'</span>) }}<span style="color: #666666"></</span>h1<span style="color: #666666">></span>
<span style="color: #666666"></</span>div<span style="color: #666666">></span>
@endsection
{{<span style="color: #666666">--</span> This is a <span style="color: #A0A000">comment</span> :<span style="color: #666666">-</span>) <span style="color: #666666">--</span>}}
@section(<span style="border: 1px solid #FF0000">'</span>main<span style="border: 1px solid #FF0000">'</span>)
<span style="color: #666666"><</span>div <span style="color: #008000; font-weight: bold">class</span><span style="color: #666666">=</span><span style="color: #BA2121">"container"</span><span style="color: #666666">></span>
<span style="color: #666666"><</span>form <span style="color: #B00040">id</span><span style="color: #666666">=</span><span style="color: #BA2121">"edit-form"</span> <span style="color: #008000; font-weight: bold">class</span><span style="color: #666666">=</span><span style="color: #BA2121">"edit-form"</span> action<span style="color: #666666">=</span><span style="color: #BA2121">"/tag/{{ $tag->id }}"</span>
data<span style="color: #666666">-</span><span style="color: #B00040">id</span><span style="color: #666666">=</span><span style="color: #BA2121">"{{ $tag->id }}"</span><span style="color: #666666">></span>
{<span style="color: #666666">!!</span> csrf_field() <span style="color: #666666">!!</span>}
<span style="color: #666666"><</span>div <span style="color: #008000; font-weight: bold">class</span><span style="color: #666666">=</span><span style="color: #BA2121">"tab-pane-group"</span><span style="color: #666666">></span>
<span style="color: #666666"><!--</span> Nav tabs <span style="color: #666666">--></span>
<span style="color: #666666"><</span>ul <span style="color: #B00040">id</span><span style="color: #666666">=</span><span style="color: #BA2121">"translation-tabs"</span> <span style="color: #008000; font-weight: bold">class</span><span style="color: #666666">=</span><span style="color: #BA2121">"nav nav-tabs"</span><span style="color: #666666">></span>
@foreach (App<span style="border: 1px solid #FF0000">\</span>Localization<span style="border: 1px solid #FF0000">\</span>Languages<span style="color: #666666">::</span>names() as <span style="border: 1px solid #FF0000">$</span>locale <span style="color: #666666">=></span> <span style="border: 1px solid #FF0000">$</span>names)
<span style="color: #666666"><</span>li <span style="color: #008000; font-weight: bold">class</span><span style="color: #666666">=</span><span style="color: #BA2121">"{{ $locale==='en'?'active':'' }}"</span><span style="color: #666666">></span>
<span style="color: #666666"><</span>a href<span style="color: #666666">=</span><span style="color: #BA2121">"#translation-{{ $locale }}"</span> data<span style="color: #666666">-</span>toggle<span style="color: #666666">=</span><span style="color: #BA2121">"tab"</span> title<span style="color: #666666">=</span><span style="color: #BA2121">"{{ $names['native'] }}"</span><span style="color: #666666">></span>
{{ <span style="border: 1px solid #FF0000">$</span>names[<span style="border: 1px solid #FF0000">'</span>localized<span style="border: 1px solid #FF0000">'</span>] }}
<span style="color: #666666"></</span>a<span style="color: #666666">></span>
<span style="color: #666666"></</span>li<span style="color: #666666">></span>
@endforeach
<span style="color: #666666"></</span>ul<span style="color: #666666">></span>
<span style="color: #666666"><!--</span> Tab panes <span style="color: #666666">--></span>
<span style="color: #666666"><</span>div <span style="color: #008000; font-weight: bold">class</span><span style="color: #666666">=</span><span style="color: #BA2121">"tab-content"</span><span style="color: #666666">></span>
@foreach (App<span style="border: 1px solid #FF0000">\</span>Localization<span style="border: 1px solid #FF0000">\</span>Languages<span style="color: #666666">::</span>all() as <span style="border: 1px solid #FF0000">$</span>locale)
<span style="color: #666666"><?</span>php <span style="border: 1px solid #FF0000">$</span>translation <span style="color: #666666">=</span> <span style="border: 1px solid #FF0000">$</span>tag<span style="color: #666666">-></span>translations()<span style="color: #666666">-></span>where(<span style="border: 1px solid #FF0000">'</span>locale<span style="border: 1px solid #FF0000">'</span>, <span style="border: 1px solid #FF0000">$</span>locale)<span style="color: #666666">-></span>first(); <span style="color: #666666">?></span>
<span style="color: #666666"><</span>div <span style="color: #B00040">id</span><span style="color: #666666">=</span><span style="color: #BA2121">"translation-{{ $locale }}"</span> <span style="color: #008000; font-weight: bold">class</span><span style="color: #666666">=</span><span style="color: #BA2121">"tab-pane {{ $locale==='en'?'active':'' }}"</span><span style="color: #666666">></span>
<span style="color: #666666"><</span>div <span style="color: #008000; font-weight: bold">class</span><span style="color: #666666">=</span><span style="color: #BA2121">"form-group"</span><span style="color: #666666">></span>
<span style="color: #666666"><</span>label<span style="color: #666666">></span>{{ trans(<span style="border: 1px solid #FF0000">'</span>common.name<span style="border: 1px solid #FF0000">'</span>) }}<span style="color: #666666"></</span>label<span style="color: #666666">></span>
<span style="color: #666666"><</span>input name<span style="color: #666666">=</span><span style="color: #BA2121">"translations[{{ $locale }}][name]"</span> value<span style="color: #666666">=</span><span style="color: #BA2121">"{{ $translation->name or '' }}"</span>
<span style="color: #008000; font-weight: bold">class</span><span style="color: #666666">=</span><span style="color: #BA2121">"form-control"</span> type<span style="color: #666666">=</span><span style="color: #BA2121">"text"</span> maxlength<span style="color: #666666">=</span><span style="color: #BA2121">"255"</span><span style="color: #666666">></span>
<span style="color: #666666"></</span>div<span style="color: #666666">></span>
<span style="color: #666666"><</span>div <span style="color: #008000; font-weight: bold">class</span><span style="color: #666666">=</span><span style="color: #BA2121">"form-group"</span><span style="color: #666666">></span>
<span style="color: #666666"><</span>label<span style="color: #666666">></span>{{ trans(<span style="border: 1px solid #FF0000">'</span>common.alias<span style="border: 1px solid #FF0000">'</span>) }}<span style="color: #666666"></</span>label<span style="color: #666666">></span>
<span style="color: #666666"><</span>input name<span style="color: #666666">=</span><span style="color: #BA2121">"translations[{{ $locale }}][alias]"</span> value<span style="color: #666666">=</span><span style="color: #BA2121">"{{ $translation->alias or '' }}"</span>
<span style="color: #008000; font-weight: bold">class</span><span style="color: #666666">=</span><span style="color: #BA2121">"form-control"</span> type<span style="color: #666666">=</span><span style="color: #BA2121">"text"</span> maxlength<span style="color: #666666">=</span><span style="color: #BA2121">"255"</span><span style="color: #666666">></span>
<span style="color: #666666"></</span>div<span style="color: #666666">></span>
<span style="color: #666666"><</span>div <span style="color: #008000; font-weight: bold">class</span><span style="color: #666666">=</span><span style="color: #BA2121">"form-group"</span><span style="color: #666666">></span>
<span style="color: #666666"><</span>label<span style="color: #666666">></span>{{ trans(<span style="border: 1px solid #FF0000">'</span>common.description<span style="border: 1px solid #FF0000">'</span>) }}<span style="color: #666666"></</span>label<span style="color: #666666">></span>
<span style="color: #666666"><</span>textarea name<span style="color: #666666">=</span><span style="color: #BA2121">"translations[{{ $locale }}][description]"</span>
<span style="color: #008000; font-weight: bold">class</span><span style="color: #666666">=</span><span style="color: #BA2121">"form-control"</span><span style="color: #666666">></span>{{ <span style="border: 1px solid #FF0000">$</span>translation<span style="color: #666666">-></span>description or <span style="border: 1px solid #FF0000">''</span> }}<span style="color: #666666"></</span>textarea<span style="color: #666666">></span>
<span style="color: #666666"></</span>div<span style="color: #666666">></span>
<span style="color: #666666"></</span>div<span style="color: #666666">></span>
@endforeach
<span style="color: #666666"></</span>div<span style="color: #666666">></span>
<span style="color: #666666"></</span>div<span style="color: #666666">></span>
<span style="color: #666666"><</span>br<span style="color: #666666">></span>
<span style="color: #666666"><</span>div <span style="color: #008000; font-weight: bold">class</span><span style="color: #666666">=</span><span style="color: #BA2121">"form-group"</span><span style="color: #666666">></span>
<span style="color: #666666"><</span>label<span style="color: #666666">></span>{{ trans(<span style="border: 1px solid #FF0000">'</span>image.cover_image<span style="border: 1px solid #FF0000">'</span>) }}<span style="color: #666666"></</span>label<span style="color: #666666">></span>
@include(<span style="border: 1px solid #FF0000">'</span>components.upload.image<span style="color: #666666">-</span>chooser<span style="border: 1px solid #FF0000">'</span>, [
<span style="border: 1px solid #FF0000">'</span><span style="color: #B00040">id</span><span style="border: 1px solid #FF0000">'</span> <span style="color: #666666">=></span> <span style="border: 1px solid #FF0000">'</span>cover<span style="color: #666666">-</span>chooser<span style="border: 1px solid #FF0000">'</span>,
<span style="border: 1px solid #FF0000">'</span>image<span style="border: 1px solid #FF0000">'</span> <span style="color: #666666">=></span> <span style="border: 1px solid #FF0000">$</span>tag<span style="color: #666666">-></span>image,
])
<span style="color: #666666"></</span>div<span style="color: #666666">></span>
<span style="color: #666666"><</span>div <span style="color: #008000; font-weight: bold">class</span><span style="color: #666666">=</span><span style="color: #BA2121">"form-group"</span><span style="color: #666666">></span>
<span style="color: #666666"><</span>label<span style="color: #666666">></span>{{ trans(<span style="border: 1px solid #FF0000">'</span>common.level<span style="border: 1px solid #FF0000">'</span>) }}<span style="color: #666666"></</span>label<span style="color: #666666">></span>
<span style="color: #666666"><</span>input name<span style="color: #666666">=</span><span style="color: #BA2121">"level"</span> value<span style="color: #666666">=</span><span style="color: #BA2121">"{{ $tag->level or '' }}"</span>
<span style="color: #008000; font-weight: bold">class</span><span style="color: #666666">=</span><span style="color: #BA2121">"form-control"</span> type<span style="color: #666666">=</span><span style="color: #BA2121">"number"</span> min<span style="color: #666666">=</span><span style="color: #BA2121">"0"</span> max<span style="color: #666666">=</span><span style="color: #BA2121">"255"</span><span style="color: #666666">></span>
<span style="color: #666666"></</span>div<span style="color: #666666">></span>
<span style="color: #666666"><</span>button type<span style="color: #666666">=</span><span style="color: #BA2121">"submit"</span> <span style="color: #008000; font-weight: bold">class</span><span style="color: #666666">=</span><span style="color: #BA2121">"btn btn-primary"</span><span style="color: #666666">></span>{{ new trans(<span style="border: 1px solid #FF0000">'</span>common.save<span style="border: 1px solid #FF0000">'</span>) }}<span style="color: #666666"></</span>button<span style="color: #666666">></span>
<span style="color: #666666"><</span>a <span style="color: #008000; font-weight: bold">class</span><span style="color: #666666">=</span><span style="color: #BA2121">"btn btn-link"</span> href<span style="color: #666666">=</span><span style="color: #BA2121">"{{ $tag->url }}"</span><span style="color: #666666">></span>{{ trans(<span style="border: 1px solid #FF0000">'</span>common.cancel<span style="border: 1px solid #FF0000">'</span>) }}<span style="color: #666666"></</span>a<span style="color: #666666">></span>
<span style="color: #666666"></</span>form<span style="color: #666666">></span>
<span style="color: #666666"></</span>div<span style="color: #666666">><!--</span> .container <span style="color: #666666">--></span>
@endsection
@push(<span style="border: 1px solid #FF0000">'</span>templates<span style="border: 1px solid #FF0000">'</span>)
@include(<span style="border: 1px solid #FF0000">'</span>templates.image<span style="color: #666666">-</span>preview<span style="border: 1px solid #FF0000">'</span>)
@endpush
@push(<span style="border: 1px solid #FF0000">'</span>modals<span style="border: 1px solid #FF0000">'</span>)
@include(<span style="border: 1px solid #FF0000">'</span>components.upload.image<span style="color: #666666">-</span>manager<span style="border: 1px solid #FF0000">'</span>)
@endpush
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/syntax/data/blade.xml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128908/diff/4/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/09/14/19bb8866-9ce0-4e2d-9880-8d1fbc7f8f37__blade.xml">Blade template highlight file</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/09/14/1a93d489-3d7c-4c27-8ff6-54c7653a3dfe__blade.xml">Blade template highlight file</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>