<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129569/">https://git.reviewboard.kde.org/r/129569/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">How is this patch coming along? Please consider moving it to Phabricator since Reviewboard is closed down soon.</p></pre>
<br />
<p>- Gregor Mi</p>
<br />
<p>On November 28th, 2016, 6:49 vorm. UTC, Janus Weil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Kate.</div>
<div>By Janus Weil.</div>
<p style="color: grey;"><em>Updated Nov. 28, 2016, 6:49 vorm.</em></p>
<div style="margin-top: 1.5em;">
<strong style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </strong>
<a href="https://bugs.kde.org/show_bug.cgi?id=372950">372950</a>
</div>
<div style="margin-top: 1.5em;">
<strong style="color: #575012; font-size: 10pt;">Repository: </strong>
syntax-highlighting
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See https://bugs.kde.org/show_bug.cgi?id=372950 for bug description and https://github.com/janusw/syntax-highlighting/commits/master for three separate commits implementing this.
Description copied from bugzilla:
Kate currently seems to have only one syntax-highlighting mode for Fortran. However, in the Fortran language there are two different source formats:
* fixed format (from the old Fortran77 standard, extension .f)
* free format (introduced with Fortran90, extension .f90)
The keywords etc are the same, but one thing that differs is commenting: In fixed format every line with a 'c' in the first column is a comment, while in free format comments start with an '!' (in any column).
Both of these mechanisms seem to be supported in Kate 16.04.3 on Ubuntu 16.10 (with Fortran highlighting file v2). The problem is that lines starting with 'c' are also displayed like a comment in f90 files (where only '!' indicates a comment).
Simple example ('test.f90'):
! this is a test program that does absolutely nothing
program test
contains
subroutine s
end subroutine
end program
The first line is greyed out, which is correct, but also the third line ('contains') is greyed out, which is wrong. It is displayed normally if a space is inserted before 'contains.'</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Opened a few different files (.f, .f90, .f03, .f08) in Kate and verified that the comments show up as expected and all artefacts disappear. A good source for test files is the testsuite of the gfortran compiler ( see e.g. https://github.com/gcc-mirror/gcc/tree/master/gcc/testsuite/gfortran.dg ).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/syntax/fortran-free.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/syntax/fortran.xml <span style="color: grey">(77c398f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129569/diff/1/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>