D22721: Clean up Kate addons CMake scripts.

[Daan De Meyer]

daandemeyer added inline comments.

INLINE COMMENTS

> turbov wrote in CMakeLists.txt:16
> Raw string literals probably could help to avoid awkward escapes:
> 
>   target_compile_definitions(
>       katebacktracebrowserplugin PRIVATE 
>       [[TRANSLATION_DOMAIN="katebacktracebrowserplugin"]]
>   )
> 
> need to test...

I'm actually not sure if the escapes are necessary anymore when using `target_compile_definitions`. I'll do some tests.

> turbov wrote in CMakeLists.txt:18
> IMHO this formatting style is much clean:
> 
>   target_link_libraries(
>     katebacktracebrowserplugin 
>     PRIVATE
>       KF5::TextEditor
>       KF5::I18n
>   )
> 
> - add the indentation after named keywords with multiple arguments
> - leave the open parentheses alone

Agreed, I'll update to this style.

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D22721

To: daandemeyer, #kate
Cc: turbov, asturmlechner, kwrite-devel, domson, michaelh, ngraham, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwrite-devel/attachments/20190724/1275beb4/attachment.html>