[Kwintv] [PATCH] devfs support for VBI decoder plugin

Richard Moore rich at xmelegance.org
Wed Jan 14 22:07:10 CET 2004


I think this is a good start towards devfs support, but a few comments:

1. I disagree with not defaulting to /dev/vbi because (as you mention) this 
works for most people. Putting some sanity checking to see if it will work is 
a good idea however.

2. It is better to use QFile::encodeName() than local8Bit() to convert a 
QString to a filename.

3. It might be better to use the Qt classes rather than calling access 
directly. This is probably a matter of opinion though.

Cheers

Rich.



More information about the kwintv mailing list