<table><tr><td style="">meven added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29791">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29791#inline-171159">View Inline</a><span style="color: #4b4d51; font-weight: bold;">rulesmodel.cpp:141</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">rule</span><span style="color: #aa2211">-></span><span class="n">key</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span style="color: #766510">"wmclasshelper"</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">setData</span><span class="p">(</span><span style="color: #aa4000">this</span><span style="color: #aa2211">-></span><span class="n">index</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">),</span> <span class="n">value</span><span class="p">,</span> <span class="n">RulesModel</span><span style="color: #aa2211">::</span><span class="n">ValueRole</span><span class="p">);</span>  <span style="color: #74777d">// wmclass := value</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">setData</span><span class="p">(</span><span style="color: #aa4000">this</span><span style="color: #aa2211">-></span><span class="n">index</span><span class="p">(</span><span style="color: #601200">2</span><span class="p">),</span> <span style="color: #304a96">true</span><span class="p">,</span> <span class="n">RulesModel</span><span style="color: #aa2211">::</span><span class="n">ValueRole</span><span class="p">);</span>   <span style="color: #74777d">// wmclasscomplete := true</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Make those index values constants or at least less hard coded.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>BRANCH</strong><div><div>wmclasscomplete</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29791">https://phabricator.kde.org/D29791</a></div></div><br /><div><strong>To: </strong>iasensio, ngraham, KWin, Plasma<br /><strong>Cc: </strong>meven, anthonyfieroni, zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>