<table><tr><td style="">zzag requested changes to this revision.<br />zzag added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29702">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29702#inline-169969">View Inline</a><span style="color: #4b4d51; font-weight: bold;">maximize_test.cpp:228-230</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QScopedPointer</span><span style="color: #aa2211"><</span><span class="n">Surface</span><span style="color: #aa2211">></span> <span class="n">surface</span><span class="p">(</span><span class="n">Test</span><span style="color: #aa2211">::</span><span class="n">createSurface</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QScopedPointer</span><span style="color: #aa2211"><</span><span class="n">XdgShellSurface</span><span style="color: #aa2211">></span> <span class="n">shellSurface</span><span class="p">(</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">Test</span><span style="color: #aa2211">::</span><span class="n">createXdgShellStableSurface</span><span class="p">(</span><span class="n">surface</span><span class="p">.</span><span class="n">data</span><span class="p">(),</span> <span class="n">surface</span><span class="p">.</span><span class="n">data</span><span class="p">(),</span> <span class="n">Test</span><span style="color: #aa2211">::</span><span class="n">CreationSetup</span><span style="color: #aa2211">::</span><span class="n">CreateOnly</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We also need to create zxdg_toplevel_decoration_v1 and tell the compositor that we prefer server-side decorations.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29702#inline-169966">View Inline</a><span style="color: #4b4d51; font-weight: bold;">maximize_test.cpp:244</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">AbstractClient</span> <span style="color: #aa2211">*</span><span class="n">client</span> <span style="color: #aa2211">=</span> <span class="n">Test</span><span style="color: #aa2211">::</span><span class="n">renderAndWaitForShown</span><span class="p">(</span><span class="n">surface</span><span class="p">.</span><span class="n">data</span><span class="p">(),</span> <span class="n">QSize</span><span class="p">(</span><span style="color: #601200">100</span><span class="p">,</span> <span style="color: #601200">50</span><span class="p">),</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">blue</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We need to ack the configure event.</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">shellSurface->ackConfigure(configureRequestedSpy.last().at(2).value<quint32>());</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29702#inline-169968">View Inline</a><span style="color: #4b4d51; font-weight: bold;">maximize_test.cpp:246-247</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QVERIFY</span><span class="p">(</span><span style="color: #aa2211">!</span><span class="n">client</span><span style="color: #aa2211">-></span><span class="n">isDecorated</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QVERIFY</span><span class="p">(</span><span class="n">client</span><span style="color: #aa2211">-></span><span class="n">noBorder</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">// but still server-side</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please check the geometry and the maximized state.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29702#inline-169967">View Inline</a><span style="color: #4b4d51; font-weight: bold;">maximize_test.cpp:249</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">// but still server-side</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">configureRequestedSpy</span><span class="p">.</span><span class="n">wait</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use QVERIFY</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29702">https://phabricator.kde.org/D29702</a></div></div><br /><div><strong>To: </strong>meven, KWin, zzag, davidedmundson<br /><strong>Cc: </strong>kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>