<table><tr><td style="">apol updated this revision to Diff 81574.<br />apol added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29278">View Revision</a></tr></table><br /><div><div><p>Address <a href="https://phabricator.kde.org/p/zzag/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@zzag</a>'s comments</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D29278?vs=81521&id=81574">https://phabricator.kde.org/D29278?vs=81521&id=81574</a></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29278">https://phabricator.kde.org/D29278</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />
abstract_client.cpp<br />
abstract_client.h<br />
abstract_output.cpp<br />
abstract_output.h<br />
abstract_wayland_output.cpp<br />
abstract_wayland_output.h<br />
autotests/CMakeLists.txt<br />
autotests/integration/dont_crash_cursor_physical_size_empty.cpp<br />
autotests/integration/globalshortcuts_test.cpp<br />
autotests/integration/idle_inhibition_test.cpp<br />
autotests/integration/input_stacking_order.cpp<br />
autotests/integration/internal_window.cpp<br />
autotests/integration/lockscreen.cpp<br />
autotests/integration/maximize_test.cpp<br />
autotests/integration/plasmawindow_test.cpp<br />
autotests/integration/pointer_constraints_test.cpp<br />
autotests/integration/pointer_input.cpp<br />
autotests/integration/scene_opengl_shadow_test.cpp<br />
autotests/integration/scene_qpainter_shadow_test.cpp<br />
autotests/integration/scene_qpainter_test.cpp<br />
autotests/integration/test_helpers.cpp<br />
autotests/integration/transient_placement.cpp<br />
autotests/integration/xdgshellclient_test.cpp<br />
autotests/integration/xwayland_input_test.cpp<br />
autotests/integration/xwayland_selections_test.cpp<br />
autotests/mock_effectshandler.h<br />
autotests/test_window_paint_data.cpp<br />
composite.cpp<br />
debug_console.cpp<br />
decorations/decorationbridge.cpp<br />
effects.cpp<br />
effects.h<br />
effects/backgroundcontrast/contrast.cpp<br />
effects/backgroundcontrast/contrast.h<br />
effects/blur/blur.cpp<br />
effects/blur/blur.h<br />
effects/desktopgrid/desktopgrid.cpp<br />
effects/slidingpopups/slidingpopups.cpp<br />
events.cpp<br />
idle_inhibition.cpp<br />
idle_inhibition.h<br />
input.cpp<br />
keyboard_input.cpp<br />
keyboard_repeat.cpp<br />
libkwineffects/CMakeLists.txt<br />
libkwineffects/kwineffects.cpp<br />
libkwineffects/kwineffects.h<br />
linux_dmabuf.cpp<br />
linux_dmabuf.h<br />
main.cpp<br />
main_wayland.cpp<br />
platform.cpp<br />
platform.h<br />
platformsupport/scenes/opengl/CMakeLists.txt<br />
platformsupport/scenes/opengl/abstract_egl_backend.cpp<br />
platformsupport/scenes/opengl/abstract_egl_backend.h<br />
platformsupport/scenes/opengl/egl_dmabuf.cpp<br />
platformsupport/scenes/opengl/egl_dmabuf.h<br />
plugins/platforms/drm/drm_backend.cpp<br />
plugins/platforms/drm/drm_inputeventfilter.cpp<br />
plugins/platforms/drm/drm_output.cpp<br />
plugins/platforms/drm/drm_output.h<br />
plugins/platforms/drm/egl_stream_backend.cpp<br />
plugins/platforms/drm/egl_stream_backend.h<br />
plugins/platforms/drm/remoteaccess_manager.cpp<br />
plugins/platforms/drm/remoteaccess_manager.h<br />
plugins/platforms/fbdev/fb_backend.cpp<br />
plugins/platforms/hwcomposer/hwcomposer_backend.cpp<br />
plugins/platforms/hwcomposer/hwcomposer_backend.h<br />
plugins/platforms/virtual/virtual_backend.cpp<br />
plugins/platforms/virtual/virtual_output.cpp<br />
plugins/platforms/wayland/egl_wayland_backend.cpp<br />
plugins/platforms/wayland/wayland_backend.cpp<br />
plugins/platforms/wayland/wayland_output.cpp<br />
plugins/platforms/x11/windowed/x11windowed_backend.cpp<br />
plugins/platforms/x11/windowed/x11windowed_output.cpp<br />
plugins/scenes/opengl/scene_opengl.cpp<br />
plugins/scenes/opengl/scene_opengl.h<br />
plugins/scenes/qpainter/scene_qpainter.cpp<br />
plugins/scenes/qpainter/scene_qpainter.h<br />
pointer_input.cpp<br />
pointer_input.h<br />
scene.cpp<br />
scene.h<br />
shadow.cpp<br />
shadow.h<br />
tablet_input.cpp<br />
toplevel.cpp<br />
toplevel.h<br />
touch_input.cpp<br />
virtualdesktops.cpp<br />
virtualdesktops.h<br />
virtualkeyboard.cpp<br />
wayland_cursor_theme.cpp<br />
wayland_server.cpp<br />
wayland_server.h<br />
xdgshellclient.cpp<br />
xdgshellclient.h<br />
xkb.cpp<br />
xkb.h<br />
xwl/clipboard.cpp<br />
xwl/clipboard.h<br />
xwl/databridge.cpp<br />
xwl/databridge.h<br />
xwl/dnd.cpp<br />
xwl/dnd.h<br />
xwl/drag_wl.cpp<br />
xwl/drag_wl.h<br />
xwl/drag_x.cpp<br />
xwl/drag_x.h<br />
xwl/selection_source.cpp<br />
xwl/selection_source.h<br />
xwl/transfer.cpp<br />
xwl/transfer.h</div></div></div><br /><div><strong>To: </strong>apol, KWin, Plasma, Frameworks, davidedmundson<br /><strong>Cc: </strong>zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>