<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29055">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D29055#inline-166467">View Inline</a><span style="color: #4b4d51; font-weight: bold;">wayland_server.cpp:496</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QVector</span><span style="color: #aa2211"><</span><span class="n">quint32</span><span style="color: #aa2211">></span> <span class="n">ids</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">auto</span> <span style="color: #a0a000">c</span><span class="p">:</span> <span class="n">workspace</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">stackingOrder</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">auto</span> <span style="color: #aa2211">*</span><span class="n">client</span> <span style="color: #aa2211">=</span> <span class="n">qobject_cast</span><span style="color: #aa2211"><</span><span class="n">AbstractClient</span><span style="color: #aa2211">*></span><span class="p">(</span><span class="n">c</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><ul class="remarkup-list">
<li class="remarkup-list-item">No short variable names please.</li>
<li class="remarkup-list-item">Don't erase types if it makes reading code more difficult</li>
</ul>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #aa4000">for</span> <span class="p">(</span><span class="n">Toplevel</span> <span style="color: #aa2211">*</span><span style="color: #a0a000">toplevel</span> <span class="p">:</span> <span class="n">workspace</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">stackingOrder</span><span class="p">())</span> <span class="p">{</span>
<span style="color: #aa4000">auto</span> <span class="n">client</span> <span style="color: #aa2211">=</span> <span class="n">qobject_cast</span><span style="color: #aa2211"><</span><span class="n">AbstractClient</span> <span style="color: #aa2211">*></span><span class="p">(</span><span class="n">toplevel</span><span class="p">);</span>
<span style="color: #74777d">// ...</span>
<span class="p">}</span></pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29055">https://phabricator.kde.org/D29055</a></div></div><br /><div><strong>To: </strong>bport, zzag, davidedmundson, meven<br /><strong>Cc: </strong>kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>