<table><tr><td style="">zzag requested changes to this revision.<br />zzag added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28674">View Revision</a></tr></table><br /><div><div><p>After some thinking, it's probably better not to merge this patch because updating current X11 time stamp asynchronously may break a lot of things on X11. On the other hand, it's highly undesired to make roundtrips to Xwayland.</p>
<p>I suggest to split this task into two sub-tasks:<br />
(a) Implement updateXTime() on Wayland. After digging through Xwayland's internals, it appears like we could use the system monotonic time as Xwayland's current X11 time stamp. For what it's worth, Mutter does the same.<br />
(b) Enable synchronized resizing for Xwayland clients. This will be a more subtle problem since Xwayland attaches a null buffer after the frame window has been resized. I don't know how to fix it yet.</p>
<p>I also would like to apologize for spotting issues with the patch too late in the code review process.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28674">https://phabricator.kde.org/D28674</a></div></div><br /><div><strong>To: </strong>meven, KWin, davidedmundson, zzag<br /><strong>Cc: </strong>kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>