<table><tr><td style="">meven created this revision.<br />meven added reviewers: davidedmundson, KWin.<br />Herald added a project: KWin.<br />Herald added a subscriber: kwin.<br />meven requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D29010">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The screenshot made on screens with scale factor were downscaled by their scale factor making them blurry.<br />
It prevents taking screenshots of missing Hidpi related bugs showing the issues under Wayland.</p>
<p>This fix the case of a single screenshot, but not the rest:<br />
Multiscreen screenshot downscales the screen using scale factor.<br />
Spectacle rectangular selection screenshot is broken as soon as some scale factor different than 1 is used on any screen.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Under Wayland with a scale factor on a screen, take a screenshot using spectacle.<br />
The output image is not downscaled and has the same size as the screen resolution.</p>
<p>No other change to any other screenshot mode, or under X.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>BRANCH</strong><div><div>screenshot</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D29010">https://phabricator.kde.org/D29010</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>effects/screenshot/screenshot.cpp<br />
effects/screenshot/screenshot.h<br />
libkwineffects/kwineffects.cpp<br />
libkwineffects/kwineffects.h<br />
plugins/scenes/opengl/scene_opengl.cpp<br />
scene.cpp<br />
scene.h</div></div></div><br /><div><strong>To: </strong>meven, davidedmundson, KWin<br /><strong>Cc: </strong>kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>