<table><tr><td style="">iasensio updated this revision to Diff 80472.<br />iasensio added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28152">View Revision</a></tr></table><br /><div><div><p>As suggested by <a href="https://phabricator.kde.org/p/ngraham/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@ngraham</a> in the <a href="https://phabricator.kde.org/tag/vdg/" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">#VDG</a> channel, this changes the metaphor to select new properti><br />
Instead of a <tt style="background: #ebebeb; font-size: 13px;">Show All</tt> filter, now we can add properties to the rule using an overlay sheet.<br />
The <tt style="background: #ebebeb; font-size: 13px;">Detect window properties</tt> option also uses the sheet to show and select them, which was a></p>

<p>There are some UI/QML quirks with the overlay I'm not able to get rid of:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">The first item in the ListView goes under the section header until it's repainted</li>
<li class="remarkup-list-item">Some items misaling the right button</li>
<li class="remarkup-list-item">Cannot set the focus to the search field</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D28152?vs=80337&id=80472">https://phabricator.kde.org/D28152?vs=80337&id=80472</a></div></div><br /><div><strong>BRANCH</strong><div><div>wip/overlay</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28152">https://phabricator.kde.org/D28152</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kcmkwin/kwinrules/CMakeLists.txt<br />
kcmkwin/kwinrules/detectwidget.cpp<br />
kcmkwin/kwinrules/detectwidget.h<br />
kcmkwin/kwinrules/detectwidget.ui<br />
kcmkwin/kwinrules/editshortcut.ui<br />
kcmkwin/kwinrules/kcm.cpp<br />
kcmkwin/kwinrules/kcm.h<br />
kcmkwin/kwinrules/kcm_kwinrules.desktop<br />
kcmkwin/kwinrules/kcmrules.cpp<br />
kcmkwin/kwinrules/kcmrules.h<br />
kcmkwin/kwinrules/kwinrules.desktop<br />
kcmkwin/kwinrules/main.cpp<br />
kcmkwin/kwinrules/optionsmodel.cpp<br />
kcmkwin/kwinrules/optionsmodel.h<br />
kcmkwin/kwinrules/package/contents/ui/FileDialogLoader.qml<br />
kcmkwin/kwinrules/package/contents/ui/OptionsComboBox.qml<br />
kcmkwin/kwinrules/package/contents/ui/RuleItemDelegate.qml<br />
kcmkwin/kwinrules/package/contents/ui/RulesEditor.qml<br />
kcmkwin/kwinrules/package/contents/ui/RulesList.qml<br />
kcmkwin/kwinrules/package/contents/ui/ValueEditor.qml<br />
kcmkwin/kwinrules/package/metadata.desktop<br />
kcmkwin/kwinrules/rulebookmodel.cpp<br />
kcmkwin/kwinrules/rulebookmodel.h<br />
kcmkwin/kwinrules/ruleitem.cpp<br />
kcmkwin/kwinrules/ruleitem.h<br />
kcmkwin/kwinrules/rulesdialog.cpp<br />
kcmkwin/kwinrules/rulesdialog.h<br />
kcmkwin/kwinrules/ruleslist.cpp<br />
kcmkwin/kwinrules/ruleslist.h<br />
kcmkwin/kwinrules/ruleslist.ui<br />
kcmkwin/kwinrules/rulesmodel.cpp<br />
kcmkwin/kwinrules/rulesmodel.h<br />
kcmkwin/kwinrules/ruleswidget.cpp<br />
kcmkwin/kwinrules/ruleswidget.h<br />
kcmkwin/kwinrules/ruleswidgetbase.ui<br />
kcmkwin/kwinrules/yesnobox.cpp<br />
kcmkwin/kwinrules/yesnobox.h</div></div></div><br /><div><strong>To: </strong>iasensio, Plasma, KWin, VDG<br /><strong>Cc: </strong>ngraham, davidedmundson, hchain, broulik, zzag, kwin, dmenig, manueljlin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, mkulinski, trickyricky26, ragreen, jackyalcine, iodelay, crozbo, ndavis, bwowk, ZrenBot, firef, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart<br /></div>