<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28668">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28668#inline-164366">View Inline</a><span style="color: #4b4d51; font-weight: bold;">wayland_server.cpp:640</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">Registry</span> <span style="color: #aa2211">*</span><span class="n">registry</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">Registry</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">            <span class="n">EventQueue</span> <span style="color: #aa2211">*</span><span class="n">eventQueue</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">EventQueue</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">this</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">EventQueue</span> <span style="color: #aa2211">*</span><span class="n">eventQueue</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">EventQueue</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">registry</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">eventQueue</span><span style="color: #aa2211">-></span><span class="n">setup</span><span class="p">(</span><span class="n">m_internalConnection</span><span class="p">.</span><span class="n">client</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Wouldn't it be better to destroy the event queue explicitly in destroyInternalConnection()? It would be a more robust (what if other globals need to access the event queue during tear down too?) and easier solution (a "flat" tear down sequence is much easier to understand than the one where children are destroyed together with their parent implicitly), imho.</p>

<p style="padding: 0; margin: 8px;">[1] In fact, we got a bug or two because of "unexpected" (technically, it was okay; but conceptually it wasn't) tear down order of parents and their children.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28668">https://phabricator.kde.org/D28668</a></div></div><br /><div><strong>To: </strong>davidedmundson, KWin, cblack, apol<br /><strong>Cc: </strong>zzag, apol, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, ahiemstra, mart<br /></div>