<table><tr><td style="">iasensio updated this revision to Diff 78984.<br />iasensio edited the summary of this revision. <a href="https://phabricator.kde.org/transactions/detail/PHID-XACT-DREV-yk25tobo4btv4aa/">(Show Details)</a><br />iasensio added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28152">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">
<li class="remarkup-list-item">Fix editing index when removing preceding rule</li>
<li class="remarkup-list-item">Move the kcm pages management to QML side</li>
<li class="remarkup-list-item">Remove helper method <tt style="background: #ebebeb; font-size: 13px;">updateState()</tt></li>
</ul></div></div><br /><div><strong>CHANGES TO REVISION SUMMARY</strong><div><div style="white-space: pre-wrap; color: #74777D;"><div style="padding: 8px 0;">...</div>After some work on the task T12729, it is almost feature-par with the previous module, and adapted to the recent move to KConfigXT.<span style="padding: 0 2px; color: #333333; background: rgba(251, 175, 175, .7);"><br />
</span></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D28152?vs=78973&id=78984">https://phabricator.kde.org/D28152?vs=78973&id=78984</a></div></div><br /><div><strong>BRANCH</strong><div><div>iasensio/kcm_kwinrules_xt</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28152">https://phabricator.kde.org/D28152</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kcmkwin/kwinrules/CMakeLists.txt<br />
kcmkwin/kwinrules/detectwidget.cpp<br />
kcmkwin/kwinrules/detectwidget.h<br />
kcmkwin/kwinrules/detectwidget.ui<br />
kcmkwin/kwinrules/editshortcut.ui<br />
kcmkwin/kwinrules/kcm.cpp<br />
kcmkwin/kwinrules/kcm.h<br />
kcmkwin/kwinrules/kcm_kwinrules.desktop<br />
kcmkwin/kwinrules/kcmrules.cpp<br />
kcmkwin/kwinrules/kcmrules.h<br />
kcmkwin/kwinrules/kwinrules.desktop<br />
kcmkwin/kwinrules/main.cpp<br />
kcmkwin/kwinrules/optionsmodel.cpp<br />
kcmkwin/kwinrules/optionsmodel.h<br />
kcmkwin/kwinrules/package/contents/ui/FileDialogLoader.qml<br />
kcmkwin/kwinrules/package/contents/ui/OptionsComboBox.qml<br />
kcmkwin/kwinrules/package/contents/ui/RuleItemDelegate.qml<br />
kcmkwin/kwinrules/package/contents/ui/RulesEditor.qml<br />
kcmkwin/kwinrules/package/contents/ui/RulesList.qml<br />
kcmkwin/kwinrules/package/contents/ui/ValueEditor.qml<br />
kcmkwin/kwinrules/package/metadata.desktop<br />
kcmkwin/kwinrules/ruleitem.cpp<br />
kcmkwin/kwinrules/ruleitem.h<br />
kcmkwin/kwinrules/rulesdialog.cpp<br />
kcmkwin/kwinrules/rulesdialog.h<br />
kcmkwin/kwinrules/ruleslist.cpp<br />
kcmkwin/kwinrules/ruleslist.h<br />
kcmkwin/kwinrules/ruleslist.ui<br />
kcmkwin/kwinrules/rulesmodel.cpp<br />
kcmkwin/kwinrules/rulesmodel.h<br />
kcmkwin/kwinrules/ruleswidget.cpp<br />
kcmkwin/kwinrules/ruleswidget.h<br />
kcmkwin/kwinrules/ruleswidgetbase.ui<br />
kcmkwin/kwinrules/yesnobox.h</div></div></div><br /><div><strong>To: </strong>iasensio, Plasma, KWin, VDG<br /><strong>Cc: </strong>davidedmundson, hchain, broulik, zzag, kwin, dmenig, manueljlin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, mkulinski, trickyricky26, ragreen, jackyalcine, iodelay, crozbo, ndavis, bwowk, ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart<br /></div>