<table><tr><td style="">zzag added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27339">View Revision</a></tr></table><br /><div><div><p>I came only halfway through the patch, but I don't think that it's a good idea to keep xdg-shell specific bits in WaylandClient.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27339#inline-160932">View Inline</a><span style="color: #4b4d51; font-weight: bold;">abstract_client.h:869</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">void</span> <span style="color: #004012">killSurface</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I don't see where it's implemented. Delete it? By the way, we have killWindow().</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27339#inline-160930">View Inline</a><span style="color: #4b4d51; font-weight: bold;">virtualkeyboard.cpp:134</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_inputSurface</span> <span style="color: #aa2211">=</span> <span class="n">waylandServer</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">createInputPanelSurface</span><span class="p">(</span><span class="n">surface</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">connect</span><span class="p">(</span><span class="n">m_inputSurface</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">KWin</span><span style="color: #aa2211">::</span><span class="n">AbstractClient</span><span style="color: #aa2211">::</span><span class="n">geometryShapeChanged</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa4000">this</span><span class="p">]</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">m_trackedClient</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use <tt style="background: #ebebeb; font-size: 13px;">frameGeometryChanged</tt> instead of <tt style="background: #ebebeb; font-size: 13px;">geometryShapeChanged</tt>.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27339#inline-160934">View Inline</a><span style="color: #4b4d51; font-weight: bold;">wayland_server.cpp:159-162</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">//not directly connected as the connection is tied to client instead of this</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">connect</span><span class="p">(</span><span class="n">m_XdgForeign</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">KWayland</span><span style="color: #aa2211">::</span><span class="n">Server</span><span style="color: #aa2211">::</span><span class="n">XdgForeignInterface</span><span style="color: #aa2211">::</span><span class="n">transientChanged</span><span class="p">,</span> <span class="n">client</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa4000">this</span><span class="p">](</span><span class="n">KWayland</span><span style="color: #aa2211">::</span><span class="n">Server</span><span style="color: #aa2211">::</span><span class="n">SurfaceInterface</span> <span style="color: #aa2211">*</span><span class="n">child</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">emit</span> <span class="n">foreignTransientChanged</span><span class="p">(</span><span class="n">child</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">});</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Leave it in <tt style="background: #ebebeb; font-size: 13px;">createSurface()</tt>. You can't use xdg-foreign with non xdg_toplevel equivalent surfaces.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27339#inline-160933">View Inline</a><span style="color: #4b4d51; font-weight: bold;">wayland_server.h:245</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">AbstractClient</span> <span style="color: #aa2211">*</span><span class="n">createInputPanelSurface</span><span class="p">(</span><span class="n">KWayland</span><span style="color: #aa2211">::</span><span class="n">Server</span><span style="color: #aa2211">::</span><span class="n">InputPanelSurfaceInterface</span> <span style="color: #aa2211">*</span><span class="n">surface</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">s/createInputPanelSurface/createInputPanelClient/</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27339">https://phabricator.kde.org/D27339</a></div></div><br /><div><strong>To: </strong>apol, KWin<br /><strong>Cc: </strong>davidedmundson, zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>