<table><tr><td style="">zzag added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28062">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28062#inline-158903">View Inline</a><span style="color: #4b4d51; font-weight: bold;">debug_console.cpp:713</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">switch</span> <span class="p">(</span><span class="n">value</span><span class="p">.</span><span class="n">type</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">case</span> <span class="n">Q<span class="bright">MetaType</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span style="color: #a0a000"><span class="bright">Q</span>Point</span><span class="p">:</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">case</span> <span class="n">Q<span class="bright">Variant</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span style="color: #a0a000">Point</span><span class="p">:</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">const</span> <span class="n">QPoint</span> <span class="n">p</span> <span style="color: #aa2211">=</span> <span class="n">value</span><span class="p">.</span><span class="n">toPoint</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">According to Qt documentation, we should interpret QVariant::Type as QMetaType::Type.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">Although this function is declared as returning QVariant::Type, the return value should be interpreted as QMetaType::Type</p></blockquote>
<p style="padding: 0; margin: 8px;"><a href="https://doc.qt.io/qt-5/qvariant.html#type" class="remarkup-link" target="_blank" rel="noreferrer">https://doc.qt.io/qt-5/qvariant.html#type</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28062#inline-158904">View Inline</a><span style="color: #4b4d51; font-weight: bold;">screenshot.cpp:661</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">// OpenGL gives RGBA; Qt wants ARGB</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">uint</span> <span style="color: #aa2211">*</span><span class="n">p</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">uint</span><span style="color: #aa2211">*<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="n">img</span><span class="p">.</span><span class="n">bits</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">uint</span> <span style="color: #aa2211">*</span><span class="n">p</span> <span style="color: #aa2211">=</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">reinterpret_cast</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><</span></span><span class="n">uint</span><span style="color: #aa2211">*<span class="bright">></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">img</span><span class="p">.</span><span class="n">bits</span><span class="p">(<span class="bright">)</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">uint</span> <span style="color: #aa2211">*</span><span class="n">end</span> <span style="color: #aa2211">=</span> <span class="n">p</span> <span style="color: #aa2211">+</span> <span class="n">w</span> <span style="color: #aa2211">*</span> <span class="n">h</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Do compilers bark about using c-style casts?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28062#inline-158905">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main_wayland.cpp:266</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">p</span><span style="color: #aa2211">-></span><span class="n">startDetached</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">p</span><span style="color: #aa2211">-></span><span class="n">deleteLater</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Indentation is off.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28062#inline-158906">View Inline</a><span style="color: #4b4d51; font-weight: bold;">aurorae.cpp:599</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">return</span> <span class="n">client</span><span class="p">().</span><span class="n">data</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span class="n">client</span><span class="p">().<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">toStrongRef</span></span><span class="bright"></span><span class="p"><span class="bright">().</span></span><span class="n">data</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Unrelated side note: this is really wrong!</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D28062#inline-158908">View Inline</a><span style="color: #4b4d51; font-weight: bold;">wayland_server.cpp:734</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">auto</span></span> <span class="n">ids<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n">m_clientIds</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">values</span></span><span class="bright"></span><span class="p"><span class="bright">().</span></span><span class="bright"></span><span class="n"><span class="bright">toSet</span></span><span class="bright"></span><span class="p"><span class="bright">(</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span class="n"><span class="bright">QSet</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright"><</span></span><span class="bright"></span><span style="color: #aa4000"><span class="bright">unsigned</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">short</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">></span></span> <span class="n">ids<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="n">m_clientIds</span><span class="p">.<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">constBegin</span></span><span class="bright"></span><span class="p"><span class="bright">(),</span></span><span class="bright"> </span><span class="n"><span class="bright">m_clientIds</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">constEnd</span></span><span class="bright"></span><span class="p"><span class="bright">()</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">quint16</span> <span class="n">id</span> <span style="color: #aa2211">=</span> <span style="color: #601200">1</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Unrelated side note: I don't get why Qt folks deprecated toSet(). Range-based initialization looks very clunky if you ask me.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28062">https://phabricator.kde.org/D28062</a></div></div><br /><div><strong>To: </strong>apol, KWin<br /><strong>Cc: </strong>zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>