<table><tr><td style="">anthonyfieroni added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D27809">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27809#inline-157134">View Inline</a><span style="color: #4b4d51; font-weight: bold;">decorationbridge.cpp:123</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">m_plugin</span> <span style="color: #aa2211">=</span> <span class="n">readPlugin</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">m_settings</span> <span style="color: #aa2211">=</span> <span class="n">QSharedPointer</span><span style="color: #aa2211"><</span><span class="n">KDecoration2</span><span style="color: #aa2211">::</span><span class="n">DecorationSettings</span><span style="color: #aa2211">>::</span><span class="n">create</span><span class="p">(</span><span style="color: #aa4000">this</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">initPlugin</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It does not have settings?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D27809#inline-157135">View Inline</a><span style="color: #4b4d51; font-weight: bold;">decorationbridge.cpp:287</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">auto</span> <span class="n">deco</span> <span style="color: #aa2211">=</span> <span class="n">m_factory</span><span style="color: #aa2211">-></span><span class="n">create</span><span style="color: #aa2211"><</span><span class="n">KDecoration2</span><span style="color: #aa2211">::</span><span class="n">Decoration</span><span style="color: #aa2211">></span><span class="p">(</span><span class="n">client</span><span class="p">,</span> <span class="n">QVariantList</span><span class="p">({</span><span class="n">args</span><span class="p">}));</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">deco</span><span style="color: #aa2211">-></span><span class="n">setSettings</span><span class="p">(</span><span class="n">m_settings</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">deco</span><span style="color: #aa2211">-></span><span class="n">init</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is there problem here?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D27809">https://phabricator.kde.org/D27809</a></div></div><br /><div><strong>To: </strong>apol, KWin<br /><strong>Cc: </strong>anthonyfieroni, kwin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>