<table><tr><td style="">cgiboudeaux added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10041">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D10041#inline-156666">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Findhwdata.cmake:37</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #304a96">find_file</span><span class="p">(</span><span style="color: #766510">hwdata_PNPIDS_FILE</span> <span style="color: #766510">NAMES</span> <span style="color: #766510">hwdata/pnp.ids</span> <span style="color: #766510">HINTS</span> <span style="color: #766510">/usr/share</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #304a96">if</span> <span class="p">(</span><span style="color: #766510">hwdata_DIR-NOTFOUND</span> <span style="color: #766510">OR</span> <span style="color: #766510">hwdata_PNPIDS_FILE-NOTFOUND</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #304a96">set</span><span class="p">(</span><span style="color: #766510">hwdata_FOUND</span> <span style="color: #766510">FALSE</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The correct syntax is <tt style="background: #ebebeb; font-size: 13px;">if (NOT hwdata_DIR_NAMES OR NOT hwdata_PNPIDS_FILE)</tt></p>

<p style="padding: 0; margin: 8px;">-NOTFOUND evaluates to FALSE [1]</p>

<p style="padding: 0; margin: 8px;">[1] <a href="https://cmake.org/cmake/help/latest/command/if.html" class="remarkup-link" target="_blank" rel="noreferrer">https://cmake.org/cmake/help/latest/command/if.html</a></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10041">https://phabricator.kde.org/D10041</a></div></div><br /><div><strong>To: </strong>dvratil, graesslin, davidedmundson, Plasma<br /><strong>Cc: </strong>cgiboudeaux, apol, feverfew, ngraham, davidedmundson, mart, kwin, sebas, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, ahiemstra<br /></div>